Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7902067

CachingTestFilter caches based on the content of a test description, not the location

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2 P2
    • None
    • None
    • tools
    • None

      This has arisen out of CODETOOLS-7902065. This is the root problem for that issue, whereas the issue itself describes a suggested solution.

      CachingTestFilter uses a HashTable<TestDescription,Boolean> to cache the results of a filter. This caches based on the *content* of the test description, and not the location of the test within the test suite. While this is OK for most filters, it means that filters based on the location of the test (specifically, ExcludeListFilter) will not be cached correctly.

      Although it will not cache as effectively, it would be better to cache results based on the location of the test, i.e. its rootRelativeURL, or use an IdentityHashMap.

            jjg Jonathan Gibbons
            jjg Jonathan Gibbons
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: