P3
Before the introduction of build-all.sh it was possible to pass BUILD_NUMBER through the environment to make.
When using build-all.sh this is not possible any more, because build-all.sh calls make without honoring if BUILD_NUMBER was set in the environment.
Notice that such a build with build-all.sh is currently useless, because it defaults to build number 'b00' (set in make/defs.gmk). Such versions of JTreg will be rejected when doing OpenJDK regression tests because the OpenJDK test have minimal build requirements in their TEST.ROOT file:
# Minimum jtreg version
requiredVersion=4.2 b08
As an extension I propose to set the build number to the latest available tag automatically, even if we're building tip because I think that's what users actually want (and need) if they want to use JTreg for executing the OpenJDK tests.
Finally, we could set the build number to something like "b11+" if "b11" was the latest tagged build but we're several changes ahead already (this woul be according to the "hg id" output which prints a "+" after the actual change hash if the working directory contains additional local changes.)
I consider this to be the best solution, but in order to work we would also have to update JTReg's build number parsing routine in com.sun.javatest.regtest.tool.Version.getBuild() which currently only accepts a plain build number (i.e. "b[0-9]+")
When using build-all.sh this is not possible any more, because build-all.sh calls make without honoring if BUILD_NUMBER was set in the environment.
Notice that such a build with build-all.sh is currently useless, because it defaults to build number 'b00' (set in make/defs.gmk). Such versions of JTreg will be rejected when doing OpenJDK regression tests because the OpenJDK test have minimal build requirements in their TEST.ROOT file:
# Minimum jtreg version
requiredVersion=4.2 b08
As an extension I propose to set the build number to the latest available tag automatically, even if we're building tip because I think that's what users actually want (and need) if they want to use JTreg for executing the OpenJDK tests.
Finally, we could set the build number to something like "b11+" if "b11" was the latest tagged build but we're several changes ahead already (this woul be according to the "hg id" output which prints a "+" after the actual change hash if the working directory contains additional local changes.)
I consider this to be the best solution, but in order to work we would also have to update JTReg's build number parsing routine in com.sun.javatest.regtest.tool.Version.getBuild() which currently only accepts a plain build number (i.e. "b[0-9]+")