Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7902479

Make trees work with Mercurial 5.0

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3 P3
    • None
    • None
    • tools
    • None

      Upstream mercurial has yet again (sigh ...) made incompatible internal API changes that have broken the openjdk trees extension.

      With hg 5.0 I see:

       $ (REPO="$HOME/ws/code-tools/trees"; for name in 'tpull' '^tpull'; do echo $name ---; /usr/bin/hg -R "$REPO" --config extensions.trees="$REPO/trees.py" $name -u; done)
      tpull ---
      hg: unknown command 'tpull'
      (did you mean one of ^tpull, pull?)
      ^tpull ---
      [/usr/local/google/home/martinrb/ws/code-tools/trees]:
      pulling from https://hg.openjdk.java.net/code-tools/trees
      searching for changes
      no changes found


      Looks like this commit:


      changeset: 40295:fa88170c10bb
      user: Rodrigo Damazio <rdamazio@google.com>
      date: 2018-10-12 18:49 +0200
      help: adding a proper declaration for shortlist/basic commands (API)

      We previously used the '^' prefix to indicate that a command
      should be shown on the short list (shown for just "hg"), but
      that's a horrible hack, so I'm removing it.

      Differential Revision: https://phab.mercurial-scm.org/D5069


      Fix should be easy - remove the '^' from trees.py
       $ grep '@command.*\^' ~/ws/code-tools/trees/trees.py
      @command("^tclone", norepo=True)
      @command('^tlog|thistory')
      @command('^tpull')
      @command('^tpush')
      @command('^tstatus')
      @command('^tupdate')

            Unassigned Unassigned
            martin Martin Buchholz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: