```
# path to javatest library (empty value allowed if you do not need jtobserver.jar)
javatestjar = javatest.jar
# path to TestNG library
testngjar = testng.jar
# path to JCommander library
jcommanderjar = jcommander.jar
```
https://github.com/openjdk/jcov/blob/e05dff3b84b9ebcd43e6f7682351861ab0aa4ef3/build/build.properties#L35
https://github.com/openjdk/jcov/blob/e05dff3b84b9ebcd43e6f7682351861ab0aa4ef3/build/build.properties#L38
https://github.com/openjdk/jcov/blob/e05dff3b84b9ebcd43e6f7682351861ab0aa4ef3/build/build.properties#L41
Asm tools have version in jar name. That is good. In addition there are hash-sums.
For javatest.jar, the version is missing but at least is somehow deductible.
For testng.jar and jcommander jar, there is no trace but commit date which added that. In addition, both testng.jar and jcommander.jar practically do not exists, as all theirs published artifacts have versions in name.
I had tried to deduct the versions combo, but never suceed in passing all tests, so I guess I wrong.
The project should use maven or apache ivy to download proper deps in build time, or at least keep and comment with proper versions to download and ideally with hashsums.
# path to javatest library (empty value allowed if you do not need jtobserver.jar)
javatestjar = javatest.jar
# path to TestNG library
testngjar = testng.jar
# path to JCommander library
jcommanderjar = jcommander.jar
```
https://github.com/openjdk/jcov/blob/e05dff3b84b9ebcd43e6f7682351861ab0aa4ef3/build/build.properties#L35
https://github.com/openjdk/jcov/blob/e05dff3b84b9ebcd43e6f7682351861ab0aa4ef3/build/build.properties#L38
https://github.com/openjdk/jcov/blob/e05dff3b84b9ebcd43e6f7682351861ab0aa4ef3/build/build.properties#L41
Asm tools have version in jar name. That is good. In addition there are hash-sums.
For javatest.jar, the version is missing but at least is somehow deductible.
For testng.jar and jcommander jar, there is no trace but commit date which added that. In addition, both testng.jar and jcommander.jar practically do not exists, as all theirs published artifacts have versions in name.
I had tried to deduct the versions combo, but never suceed in passing all tests, so I guess I wrong.
The project should use maven or apache ivy to download proper deps in build time, or at least keep and comment with proper versions to download and ideally with hashsums.
- links to
-
Review openjdk/jcov/40