Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7903937

JTREG uses timeout factor on socket timeout but not on KEEPALIVE

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • tools
    • None

      In AgentServer.java `s.setSoTimeout((int)(KeepAlive.READ_TIMEOUT * timeoutFactor));` is scaling the timeout using `timeoutFactor`. However, when sending `KEEPALIVE` messages, the timeout is not scaled using the timeout factor. Personally, it seems strange to use the timeout factor for this use case, but if we use it, we should use it for both parts.

      I think the best fix is to remove timeoutFactor in three places in Agent.java and AgentServer.java when setting socket timeout. Otherwise, the socket might time out if you use a timeoutFactor that is less than ~0.5.

            Unassigned Unassigned
            lkorinth Leo Korinth
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: