Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4125968

quickFieldAccess() semantic error in file interpreter.c, missing "else" logic

XMLWordPrintable

    • 1.2beta4
    • generic
    • generic
    • Not verified

      Semantic problem within code - missing "else" in method quickFieldAccess from
      file share/javavm/runtime/interpreter.c

      On the line following "result = 1;" these is an if statement.
      There is supposed to be an else between the } and the if .

          } else {
      unsigned int offset = fb->u.offset / sizeof (OBJECT);
      CODE_LOCK(EE2SysThread(ee));
      if (pc[0] != opcode && pc[0] != opc_breakpoint) {
      result = 1;
      } if (offset <= 0xFF && !UseLosslessQuickOpcodes) {
      ^
      ^
      |
      |
      there should be
                   an "else" here.


      int delta = (signature[0] == SIGNATURE_LONG
      || signature[0] == SIGNATURE_DOUBLE)
      ? (opc_getfield2_quick - opc_getfield)
      : (opc_getfield_quick - opc_getfield);
      rewriteByte(pc, 1, offset);
      sysStoreBarrier();
      rewriteByte(pc, 0, opcode + delta);
      } else {
      int delta = (opc_getfield_quick_w - opc_getfield);
      rewriteByte(pc, 0, opcode + delta);
      }
      CODE_UNLOCK(EE2SysThread(ee));
          }
          return result;
      }

            never Tom Rodriguez
            jbenoit Jonathan Benoit (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: