Name: sdC67446 Date: 06/10/98



methods java.beans.beancontext.BeanContextServicesSupport.
    addBeanContextServicesListener(BeanContextServicesListener bcsl) and
    removeBeanContextservicesListener(BeanContextservicesListener bcsl)
permit 'bcsl' == null.

Thus consequent call of fireServiceAdded/fireServiceRevoked throws
undocumented NullPointerException if addBeanContextServicesListener(null)
has been called previously.
Method addBeanContextServicesListener(null) should throw NullPointerException.

Method removeBeanContextServiceListener(null) should throw NullPointerException
otherwise it should be stated in documentation.

The doc says:
--------------------------------------------------
public void addBeanContextServicesListener(BeanContextServicesListener bcsl)

      add a BeanContextServicesListener
      Specified by:
            addBeanContextServicesListener in interface BeanContextServices

public void removeBeanContextServicesListener(BeanContextServicesListener bcsl)

      remove a BeanContextServicesListener
      Specified by:
            removeBeanContextServicesListener in interface BeanContextServices

Here is the test demostrating the bug:
--------------------------------------------------
import java.beans.beancontext.*;

public class Test extends BeanContextServicesSupport {

    public Test() {
         super();
    }

    public void fireServiceAddedSpy(Class c) {
        super.fireServiceAdded(c);
    }

    public static void main(String[] args) {

        Test test = new Test();
        test.removeBeanContextServicesListener(null);
        test.addBeanContextServicesListener(null);
        try {
            test.fireServiceAddedSpy(test.getClass());
        } catch (NullPointerException e) {
            System.out.println("unexpected "+e);
        }

    }
}

Here is test's output:
--------------------------------------------------
unexpected java.lang.NullPointerException
--------------------------------------------------
======================================================================