-
Bug
-
Resolution: Not an Issue
-
P4
-
None
-
1.2.0
-
x86
-
windows_nt
While investigate the Bug 4148221, I found the win32 awt native hook code is risky and fragile.
The hook awt installed is used for detecting the mouse enter/exit event, which are not generated by win32. That piece of code contains the bug 4150851. In many cases, the Frame window is special window because it contains the non-client area. It should be treated differently.
The other duty of the hook (maybe) is to install the input method. However it may have significant conflicts with other input method installed on the system. The code of AwtComponent::PreProcessMsg() may have potential problems.
There is also a coding style error. The ProProcessMsg returns BOOL, and it is used to compare with mrPassAlong (an enum), see line 589 of awt_Toolkit.cpp, that makes the code confusing.
The hook awt installed is used for detecting the mouse enter/exit event, which are not generated by win32. That piece of code contains the bug 4150851. In many cases, the Frame window is special window because it contains the non-client area. It should be treated differently.
The other duty of the hook (maybe) is to install the input method. However it may have significant conflicts with other input method installed on the system. The code of AwtComponent::PreProcessMsg() may have potential problems.
There is also a coding style error. The ProProcessMsg returns BOOL, and it is used to compare with mrPassAlong (an enum), see line 589 of awt_Toolkit.cpp, that makes the code confusing.