Name: ksC84122 Date: 03/12/99


java.lang.SecurityManager methods:
public void checkConnect(String host, int port) (port != -1)
public void checkMemberAccess(Class clazz, int which)
public void checkPackageAccess(String pkg)
public void checkPackageDefinition(String pkg)
public void checkRead(FileDescriptor fd)
public boolean checkTopLevelWindow(Object window)
public void checkWrite(FileDescriptor fd)

perform checking actions despite parameter passed to them is null.
Those checks are meaningless and should not be performed.
The typical example is for checkConnect(null, 1) method, it causes:
checkPermission(new SocketPermission("null:1", "connect,resolve")).
It does not make sense.

The behavior in case of null parameter is not specified in the javadoc
for above mentioned methods, but it would make sense if these methods
throw NullPointerException to avoid meaningless checks.

A test example which demonstrates this problem.
===== test43.java ========
import java.io.FileDescriptor;

public class test43 {

   public static void main (String argv[]) {
       SecurityManager sec = new SecurityManager();
       
       try {
           sec.checkConnect((String)null, 5);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }
       try {
           sec.checkLink(null);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }
       try {
           sec.checkMemberAccess((Class)null, 5);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }

       try {
           sec.checkPackageDefinition((String)null);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }
       try {
           sec.checkRead((FileDescriptor)null);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }
       try {
           sec.checkTopLevelWindow(null);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }
       try {
           sec.checkWrite((FileDescriptor)null);
           System.out.println("Failed: NullPointerException expected");
           return;
       } catch (NullPointerException npe) { //OKAY
       }
       
       System.out.println("Passed.");
       return;
  }
}

========= Sample run (JDK1.2.1) ==========
#>java test43
Exception in thread "main" java.security.AccessControlException: access denied (java.net.SocketPermission null:5
connect,resolve)
        at java.security.AccessControlContext.checkPermission(AccessControlContext.java, Compiled Code)
        at java.security.AccessController.checkPermission(AccessController.java, Compiled Code)
        at java.lang.SecurityManager.checkPermission(SecurityManager.java, Compiled Code)
        at java.lang.SecurityManager.checkConnect(SecurityManager.java, Compiled Code)
        at test43.main(test43.java, Compiled Code)


======================================================================