Name: vi73552 Date: 06/14/99


Further to bugs #4195507, #4180832, #4185691 and #4193257 I'm seeing another problem:

The KeyboardManager never cleans up a reference to a Window (JFrame or JDialog) which has a menu bar. The methods registerMenuBar and unregisterMenuBar are invoked; the registerMenuBar will invoke registerNewTopContainer if it hasn't been registered already; however, the only logic inside KeyboardManager which ever frees up the reference in containerMap is unregisterKeyStroke which isn't guaranteed to be called. unregisterMenuBar should take care of this...

The code I've used for the test is:

public class TestFrame extends JFrame
{
   public TestFrame(String title)
   {
      super(title);


      JMenuBar menuBar;
      JMenu menu;
      JMenuItem menuItem;


      menuBar = new JMenuBar();
      menu = new JMenu("File");
      menuBar.add(menu);
      menuItem = new JMenuItem("Exit", 'x');
      menu.add(menuItem);
      setJMenuBar(menuBar);
   }

   public void dispose()
   {
      super.dispose();
      removeAll();
   }
}

by calling removeAll() I get rid of the InputMethod reference leak; if I comment out the setJMenuBar(menuBar) method invocation, the frame gets cleaned up; if not, OptimizeIt 3.0 reports the above mentioned reference inside the KeyboardManager instance's containerMap variable.

I a development tool which launches several JFrames with different tools, the amount of memory leakage quickly becomes a problem...
(Review ID: 84314)
======================================================================

Name: skT88420 Date: 10/11/99


This is different than the previous JFrame bug.

Run this and bring up several windows using the "Add" button.
Close them by using the X on the Windows title bar.
Press the GC button.

Most, but not all of the JFrames are collected. It seems that
the last one closed is not collected.

Add more windows.
In each of these windows, pull down the menu and select the action.
These windows will never be collected, however the window that
would not be collected during the first test will be now.

A single hanging JFrame can keep lots of Objects from being collected.

-----------------------------------
CODE:

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;

final public class SunTest16 extends JFrame {

int count = 0;

public SunTest16() {
super("Bug");
Container contentPane = getContentPane();
contentPane.setLayout(new FlowLayout());

JButton b = new JButton("Add");
b.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent e) {
MyClass o = new MyClass(++count);
o.setSize(200,200);
o.show();
}
});
contentPane.add(b);

b = new JButton("GC");
b.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent e) {
System.gc();
}
});
contentPane.add(b);
addWindowListener(new WindowAdapter() {
public void windowClosing(WindowEvent e) {
dispose();
System.exit(0);
}
});
}
public static void main(String[] args) {
SunTest16 s = new SunTest16();
s.setSize(400,300);
s.show();
}
public static class MyClass extends JFrame {
JMenuBar menubar;
int count;

public MyClass(int count) {
super("Frame: " + count);
this.count = count;

Container contentPane = getContentPane();
contentPane.setLayout(new BorderLayout());

menubar = new JMenuBar();
JMenu m = new JMenu("Test");
Action a = new AbstractAction("Action") {
public void actionPerformed(ActionEvent e) {
System.out.println("Action");
}
};

m.add(a);
menubar.add(m);

contentPane.add(menubar,BorderLayout.NORTH);

addWindowListener(new WindowAdapter() {
public void windowClosing(WindowEvent e) {
//System.out.println("Closing");
dispose();
}
});
}
public void finalize() throws Throwable {
System.out.println("Finalizing frame: " + count);
super.finalize();
}
public void dispose() {
//System.out.println("Disposing frame: " + count);
super.dispose();
}
}
}
(Review ID: 96395)
======================================================================