Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4317988

CompoundBorder.isBorderOpaque() wrong implementation!

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.4.0
    • 1.3.0
    • client-libs
    • beta
    • generic
    • generic



      Name: skT88420 Date: 03/01/2000


      Here I send you the patch I had to make to the isBorderOpaque(),
      I left your implementation under comment!

      You can see, that using your implementation the compound border
      returns false if the outsideBorder is null, without asking the
      insideBorder!

          /**
           * Returns whether or not this compound border is opaque.
           * Returns true if both the inside and outside borders are
           * non-null and opaque; returns false otherwise.
           */
          public boolean isBorderOpaque() {
      // Patch:
      return (outsideBorder == null || outsideBorder.isBorderOpaque()) &&
                     (insideBorder == null || insideBorder.isBorderOpaque());
      // End Patch
      // return (outsideBorder != null && outsideBorder.isBorderOpaque()) &&
      // (insideBorder != null && insideBorder.isBorderOpaque());
          }

      Thanks
        Patrick
      (Review ID: 95682)
      ======================================================================

            amfowler Anne Fowler (Inactive)
            skonchad Sandeep Konchady
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: