Name: krT82822 Date: 03/12/2000


(1.2.2 and kestrel-rc1)

At lines 909, 930, and 934 (of the v1.2.2 source) the code throws an Error
object. Since Errors are not subclasses of RuntimeExceptions, they are very
nasty to catch. Besides, your Errors for invalid HTML are hardly worthy of the
importance associated with ThreadDeath, VirtualMachineError, and
ClassFormatError.

Here is a partial trace of when I found this nasty peice of code:

java.lang.Error: Can't build a BranchElement(section) 0,48
at javax.swing.text.html.HTMLEditorKit$HTMLFactory.create
(HTMLEditorKit.java:934)
at javax.swing.plaf.basic.BasicTextUI.modelChanged(BasicTextUI.java:372)
at javax.swing.plaf.basic.BasicTextUI$UpdateHandler.propertyChange
(BasicTextUI.java:1382)
at javax.swing.event.SwingPropertyChangeSupport.firePropertyChange
(SwingPropertyChangeSupport.java:154)
at javax.swing.JComponent.firePropertyChange(JComponent.java:3023)
at javax.swing.text.JTextComponent.setDocument(JTextComponent.java:651)
at javax.swing.JTextPane.setDocument(JTextPane.java:95)

I recommend adding an InvalidHTMLException extends RuntimeException for this.
(Review ID: 102090)
======================================================================