Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4367288

BasicTabbedPaneUI htmlViews is private but subclasses need it for drawing

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.4.0
    • 1.3.0
    • client-libs
    • beta
    • generic
    • generic



      Name: ks88420 Date: 08/30/2000


      java version "1.2.2"
      (you do know that there's no command line in the shipping Mac OS?)

      >>>
      >>>On Thu, Aug 17, 2000 at 03:46:11PM -0700, Lee Ann Rucker wrote:
      >> Scott Violet wrote:
      > Amy Fowler wrote:

      >>>> BasicTabbedPaneUI.paintText does the wrong thing for the Mac plaf, so I
      >>>> don't call it. But it also does the html rendering, which depends on the
      >>>> private variable htmlViews. Judging from the comments on
      >>>> ContainerHandler, I shouldn't be calling isHTMLString during rendering
      >>>> because it's expensive.
      >>>>
      >>>> Is it OK if I make htmlViews protected?
      >>>
      >>>I would say that it should remain private. If you need access to it,
      >>>BasicTabbedPaneUI should have some a getter that takes an index and
      >>>returns the View.
      >>>Amy, what do you think?
      >
      >I agree. In the past, we've errored on making more things protected
      >than should be.
      (Review ID: 109104)
      ======================================================================

            amfowler Anne Fowler (Inactive)
            skonchad Sandeep Konchady
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: