Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4421515

Need changes to new InputEvent modifier APIs

XMLWordPrintable

    • beta2
    • generic, x86
    • generic, windows_2000

      Based on a Design Review meeting held between Swing and AWT, the
      following changes were recommended:

      The CHANGED mask values should be removed.

      A new modifer, ALT_GRAPH_DOWN should be added.

      Extensive documentation should be added to explain how to use the new APIs,
      with examples.

      Here is a list of places where the CHANGED mask is used.


      echawkes@jano:/net/jano/export/disk03/awt/echawkes/jdk14-52/src( 99 )% findref -skipdir SCCS BUTTON | grep CHANGED
      ./share/classes/java/awt/event/InputEvent.java(125): public static final int BUTTON1_CHANGED_MASK = 1 << 13;
      ./share/classes/java/awt/event/InputEvent.java(130): public static final int BUTTON2_CHANGED_MASK = 1 << 14;
      ./share/classes/java/awt/event/InputEvent.java(135): public static final int BUTTON3_CHANGED_MASK = 1 << 15;
      ./share/classes/java/awt/event/MouseEvent.java(345): if ((modifiers & BUTTON1_CHANGED_MASK) != 0) {
      ./share/classes/java/awt/event/MouseEvent.java(347): } else if ((modifiers & BUTTON2_CHANGED_MASK) != 0) {
      ./share/classes/java/awt/event/MouseEvent.java(349): } else if ((modifiers & BUTTON3_CHANGED_MASK) != 0) {
      ./share/classes/java/awt/event/MouseEvent.java(431): modifiers |= BUTTON1_CHANGED_MASK;
      ./share/classes/java/awt/event/MouseEvent.java(437): modifiers |= BUTTON2_CHANGED_MASK;
      ./share/classes/java/awt/event/MouseEvent.java(443): modifiers |= BUTTON3_CHANGED_MASK;

      ./solaris/native/sun/awt/canvas.c(755): return java_awt_event_InputEvent_BUTTON1_CHANGED_MASK
      ./solaris/native/sun/awt/canvas.c(758): return java_awt_event_InputEvent_BUTTON2_CHANGED_MASK
      ./solaris/native/sun/awt/canvas.c(761): return java_awt_event_InputEvent_BUTTON3_CHANGED_MASK
      ./solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java(73): InputEvent.BUTTON1_CHANGED_MASK |
      ./solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java(74): InputEvent.BUTTON2_CHANGED_MASK |
      ./solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java(75): InputEvent.BUTTON3_CHANGED_MASK |
      ./win32/native/sun/windows/awt_Choice.cpp(190): if (id == java_awt_event_MouseEvent_MOUSE_PRESSED && !(modifiers & java_awt_event_InputEvent_BUTTON1_CHANGED_MASK)) {
      ./win32/native/sun/windows/awt_Choice.cpp(194): if (id == java_awt_event_MouseEvent_MOUSE_RELEASED && !(modifiers & java_awt_event_InputEvent_BUTTON1_CHANGED_MASK)) {
      ./win32/native/sun/windows/awt_Component.cpp(1958): modifiers |= java_awt_event_InputEvent_BUTTON1_CHANGED_MASK;
      ./win32/native/sun/windows/awt_Component.cpp(1961): modifiers |= java_awt_event_InputEvent_BUTTON3_CHANGED_MASK;
      ./win32/native/sun/windows/awt_Component.cpp(1964): modifiers |= java_awt_event_InputEvent_BUTTON2_CHANGED_MASK;
      ./win32/classes/sun/awt/windows/WMouseDragGestureRecognizer.java(69): InputEvent.BUTTON1_CHANGED_MASK |

            ssisunw Ssi Ssi (Inactive)
            ehawkessunw Eric Hawkes (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: