Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4421986

Poor identifiers in java.text.Bidi class

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2 P2
    • 1.4.0
    • 1.4.0
    • core-libs
    • beta2
    • generic
    • generic

      RFE 4285083 added a new class java.text.Bidi. This class has a number of poorly chosen identifiers:

      - "Bidi" is an abbreviation that's known only to a select few people. The class should be named "BidirectionalLayout".

      - The constants in the class all start with the prefix "FLAG". This prefix doesn't explain anything and therefore should be dropped.

      - The constants and several methods in the class use abbreviations such as "DIR" or "LTR". These should be spelled out "DIRECTION" and "LEFT_TO_RIGHT".

      - The methods createLineBidi and requiresBidi should be renamed to createLineBidirectionalLayout and requiresBidirectionalLayout to match the new class name.

      Also, the @since tag is missing from the class.

            nlindenbsunw Norbert Lindenberg (Inactive)
            nlindenbsunw Norbert Lindenberg (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: