Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4428550

make/java/hprof/Makefile has direct command invocation of mkdir

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2 P2
    • 1.4.0
    • 1.4.0
    • infrastructure
    • None
    • beta
    • generic
    • generic



      Name: dm26566 Date: 03/21/2001


      Direct command invocations are not acceptable in J2SE make files. Instead,
      the corresponding command variable should be used:

      #
      # Install the hprof prelude
      #
      $(LIBDIR)/jvm.hprof.txt: $(SHARE_SRC)/tools/hprof/jvm.hprof.txt
              -$(RM) $@
              mkdir -p $(LIBDIR)
              $(CP) $< $@

      ($MKDIR) should be use instead of mkdir.

      Actually, the use of $(MKDIR) or mkdir are both incorrect because they
      mask a depency of this rule on $(LIBDIR), so the rule should really be:

      #
      # Install the hprof prelude
      #
      $(LIBDIR)/jvm.hprof.txt: $(SHARE_SRC)/tools/hprof/jvm.hprof.txt $(LIBDIR)
              -$(RM) $@
              $(CP) $< $@

      ======================================================================

            dmcduffisunw Dale Mcduffie (Inactive)
            dmcduffisunw Dale Mcduffie (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: