Name: ddT132432 Date: 08/24/2001


java version "1.3.1"
Java(TM) Runtime Environment, Standard Edition (build 1.3.1-b24)
Java Hotspot(TM) Client VM (build 1.3.1-b24, mixed mode)

When the menubar object attached to a JFrame window is replaced, the new bar is
not displayed correctly in the Metal L&F. It looks like that the dimensions of
the menu names in the new bar are not handled correctly, making the menubar
displayed garbled, and mouse actions impossible. This problem also occurs using
JDK1.4 beta.

The attached program shows this problem, and also implements a workaround that
was found. Note that keyboard actions will be executed correctly - even if the
menubar is shown garbled - so that these can still be used to execute any
actions.

The following code fragment is a usable program that allows the reproduction of
the bug, and the test of the workaround.

Steps to take:
select file then setMainBar(). ==> menubar will not draw correctly but key events still work.


================================= start MainTest.java ==========================

/*
 * MainTest.java
 *
 * Created on August 23, 2001, 1:08 PM
 *
 * Copyright 2001, Hut Software, The Netherlands.
 */

package com.hutsoftware.MenuBarTest;
import javax.swing.*;
import java.awt.event.ActionEvent;
import java.awt.event.KeyEvent;

/**
 *
 * @author geertjan
 * @version
 */
public class MainTest extends JFrame {
    JMenuBar bar;
    JMenuBar newBar;
    boolean threads=false;
    boolean useRootPane=false;
    boolean heavy=false;
    boolean updateUIworkaround=false;
    JMenu[] menus=new JMenu[5];
    
    Thread changeBarThread= new Thread() {
        public void run(){
            try {
                sleep(100);
            }catch (InterruptedException e) {};
            
            bar=newBar;
            if (useRootPane){
                getRootPane().setJMenuBar(bar);
                System.out.println("Set new bar in thread with rootpane");
            }else{
                setJMenuBar(bar);
                System.out.println("Set new bar in thread");
            }
            
            if (updateUIworkaround){
                bar.updateUI();
                System.out.println("UI updated");
            }
        }
    };
    

    private void changeBar(JMenuBar bar){
        if (threads){
            newBar=bar;

            changeBarThread.start();
            System.out.println("thread started.. ");
        }else{
            this.bar=bar;

            if (useRootPane){
                getRootPane().setJMenuBar(bar);
            }else{
                setJMenuBar(bar);
            }

            if (updateUIworkaround){
                bar.updateUI();
                System.out.println("UI updated");
            }
        }
    }
        
    
    AbstractAction newAction=new AbstractAction("setInitBar") {
        public void actionPerformed(ActionEvent evt){
            // change menubar with extra actions.....
            changeBar(new InitMenuBar());
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    AbstractAction openAction=new AbstractAction("setMainBar") {
        public void actionPerformed(ActionEvent evt){
            // change menubar with extra actions.....
            changeBar(new MainMenuBar());
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };
    
    AbstractAction exitAction=new AbstractAction("Exit") {
        public void actionPerformed(ActionEvent evt){
            System.out.println(evt.getActionCommand()+" action performed");
            System.exit(0);
        }
    };
    
    AbstractAction helpAction=new AbstractAction("Help") {
        public void actionPerformed(ActionEvent evt){
            // do nothing for now...
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    AbstractAction aboutAction=new AbstractAction("About") {
        public void actionPerformed(ActionEvent evt){
            // do nothing for now...
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    AbstractAction threadToggleAction=new AbstractAction("Threads toggle") {
        public void actionPerformed(ActionEvent evt){
            // enable separate threads...
            if (heavy){
                threads=false;
                System.out.println("threads => false");
            }else{
                threads=true;
                System.out.println("threads => true");
            }

            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    AbstractAction rootPaneToggleAction=new AbstractAction("RootPane toggle") {
        public void actionPerformed(ActionEvent evt){
            
            if (useRootPane){
                useRootPane=false;
                System.out.println("useRootPane => false");
            }else{
                useRootPane=true;
                System.out.println("useRootPane => true");
            }
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    AbstractAction updateUIToggleAction=new AbstractAction("updateUI toggle") {
        public void actionPerformed(ActionEvent evt){
            
            if (updateUIworkaround){
                updateUIworkaround=false;
                System.out.println("updateUIworkaround => false");
            }else{
                updateUIworkaround=true;
                System.out.println("updateUIworkaround => true");
            }
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    
    AbstractAction heavyToggleAction=new AbstractAction("Heavy Toggle") {
        public void actionPerformed(ActionEvent evt){
            
            if (heavy){
                heavy=false;
                System.out.println("heavy => false");
            }else{
                heavy=true;
                System.out.println("heavy => true");
            }
            
            for(int i=0;i<menus.length;i++){
                if (menus[i]!=null){
                    menus[i].getPopupMenu().setLightWeightPopupEnabled(heavy);
                }
            }
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };
    
    AbstractAction repaintAction=new AbstractAction("Repaint") {
        public void actionPerformed(ActionEvent evt){
            
            invalidate();
            repaint();
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    private void changeLF(String className){
        
        try {
            UIManager.setLookAndFeel(className);
            SwingUtilities.updateComponentTreeUI(this);
        }catch(ClassNotFoundException e){
            System.out.println("Class not found");
        }catch(InstantiationException e){
            System.out.println("InstantiationException");
        }catch(IllegalAccessException e){
            System.out.println("IllegalAccessException");
        }catch(UnsupportedLookAndFeelException e){
            System.out.println("UnsupportedLookAndFeelException");
        }
    }
        
    
    AbstractAction metalLFAction=new AbstractAction("Metal L&F") {
        public void actionPerformed(ActionEvent evt){
            
            changeLF("javax.swing.plaf.metal.MetalLookAndFeel");
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };
    AbstractAction motifLFAction=new AbstractAction("Motif L&F") {
        public void actionPerformed(ActionEvent evt){
            
            changeLF("com.sun.java.swing.plaf.motif.MotifLookAndFeel");
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };
    AbstractAction windowsLFAction=new AbstractAction("Windows L&F") {
        public void actionPerformed(ActionEvent evt){

            changeLF("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
            
            System.out.println(evt.getActionCommand()+" action performed");
        }
    };

    public class InitMenuBar extends JMenuBar {
        
        InitMenuBar(){
            // first add file menu...
            menus[0] = new JMenu("File");
            menus[0].setMnemonic('F');

            JMenuItem item=menus[0].add(newAction);
            item.setMnemonic('N');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_N,java.awt.Event.ALT_MASK));

            item=menus[0].add(openAction);
            item.setMnemonic('O');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_O,java.awt.Event.ALT_MASK));

            menus[0].addSeparator();

            item=menus[0].add(exitAction);
            item.setMnemonic('X');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_X,java.awt.Event.ALT_MASK));

            menus[0].addSeparator();

            add(menus[0]);

            // add modifiers menu...
            menus[1] = new JMenu("Modifiers");
            menus[1].setMnemonic('M');

            item=menus[1].add(threadToggleAction);
            item.setMnemonic('T');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_H,java.awt.Event.ALT_MASK));

            item=menus[1].add(rootPaneToggleAction);
            item.setMnemonic('R');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_R,java.awt.Event.ALT_MASK));
            
            item=menus[1].add(heavyToggleAction);
            item.setMnemonic('Q');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_Q,java.awt.Event.ALT_MASK));

            item=menus[1].add(repaintAction);
            item.setMnemonic('E');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_E,java.awt.Event.ALT_MASK));

            item=menus[1].add(metalLFAction);
            item.setMnemonic('M');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_M,java.awt.Event.ALT_MASK));
            item=menus[1].add(motifLFAction);
            item.setMnemonic('F');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_F,java.awt.Event.ALT_MASK));
            item=menus[1].add(windowsLFAction);
            item.setMnemonic('W');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_W,java.awt.Event.ALT_MASK));
            item=menus[1].add(updateUIToggleAction);
            item.setMnemonic('T');
           
item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_T,java.awt.Event.ALT_MASK));
            
            add(menus[1]);

            // add help menu...
            menus[2] = new JMenu("Help");
            menus[2].setMnemonic('H');

            item=menus[2].add(helpAction);
            item.setMnemonic('H');
            item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_F1,0));

            item=menus[2].add(aboutAction);
            item.setMnemonic('A');

            add(menus[2]);
        }
        
    }
    
    public class MainMenuBar extends InitMenuBar {
        MainMenuBar(){
            super();
            // add help menu again, to check whether menubar really changed....
            menus[3] = new JMenu("Main");
            menus[3].setMnemonic('M');

            JMenuItem item=menus[3].add(helpAction);
            item.setMnemonic('H');
            item.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_F1,0));

            item=menus[3].add(aboutAction);
            item.setMnemonic('A');

            add(menus[3]);
        }
    }
    
    
    /** Creates new MainTest */
    public MainTest() {
        JDesktopPane mainDesktop = new JDesktopPane();
        
        setTitle("JMenuBarTest");
        addWindowListener(new java.awt.event.WindowAdapter() {
            public void windowClosing(java.awt.event.WindowEvent evt) {
                System.exit(0);
            }
        });
        
        mainDesktop.setPreferredSize(new java.awt.Dimension(600, 400));
        mainDesktop.setMinimumSize(new java.awt.Dimension(100, 100));
        getContentPane().add(mainDesktop, java.awt.BorderLayout.CENTER);
        
        pack();
        
        InitMenuBar bar=new InitMenuBar();
        // added separately, as subclasses might want to add menu's in between..

        setJMenuBar(bar);
    }
    
    public static void main(String Args[]){
        new MainTest().show();
    }
}



================================= end MainTest.java ============================
(Review ID: 130624)
======================================================================