Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4903553

java.lang.annotation APIs not aligned with spec

    XMLWordPrintable

Details

    • generic
    • solaris_8

    Description

      The following are code review comments from ###@###.###
      of the initial set of changes for annotations in J2SE
      They should be addressed before beta:

      =====

      java/lang/annotation/ElementType.java
        Missing the associated javadoc for each enum constant which
        appears in the spec.

      java/lang/annotation/Target.java
        [38] "ANNOTATION" in code does not match spec "ANNOTATION_TYPE"

        Spec - Declaration of Target.value missing "()".

      java/lang/annotation/Target.java
        [22] "ANNOTATION" in code does not match spec "ANNOTATION_TYPE"

      java/lang/annotation/VisibilityLevel.java
        Spec renames to "RetentionPolicy". Missing javadoc which appears in
        the spec.

      java/lang/annotation/Visibility.java
        [10 - 33] Spec is vaguely similar to that in source.

        [39] Missing @Retention(RUNTIME)

        [40] "ANNOTATION" in code does not match spec "ANNOTATION_TYPE"

      java/lang/annotation/Inherited.java

        [41] "ANNOTATION" in code does not match spec "ANNOTATION_TYPE"

      java/lang/Overrides.java

        [13 - 16] Spec vaguely similar to that in source.

      Attachments

        Issue Links

          Activity

            People

              jjb Josh Bloch
              gafter Neal Gafter
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Imported:
                Indexed: