The static analyzer 'findbugs' report indicates some minor code cleanup of the JNDI code.

In part-I of the cleanup, the following fixes are being made. There are a few more left that need more analysis to be covered in the part-II of the cleanup.

Part-I:

o Method invokes dubious new String(String) constructor; just use the argument

Classes:
        javax/naming/ldap/StartTlsRequest.java
        com/sun/jndi/ldap/LdapSchemaParser.java

o Comparison of String objects using == or !=

        com/sun/jndi/ldap/LdapCtx.java
        com/sun/jndi/url/jndi/jndiURLContextFactory.java

o Iterator next() method can't throw NoSuchElement exception

        com/sun/jndi/toolkit/dir/LazySearchEnumerationImpl.java
        com/sun/naming/internal/FactoryEnumeration

o Method may fail to close stream

        com/sun/jndi/cosnaming/CNCtx.java

o Possible null pointer dereference in method

        com/sun/jndi/nis/NISCtxServices.java

o Redundant comparison to null

        com/sun/jndi/dsml/JndiToDsml.java
        com/sun/jndi/internal/onc/rpc/rpc_client_bc.java

o Should be a static inner class?

        com/sun/jndi/ldap/EventQueue.java
        com/sun/naming/internal/VersionHelper12.java

o Unread field

        com.sun.jndi.dns.Header.opcode
        com.sun.jndi.dns.Header.recursionAvail
        com.sun.jndi.dns.Header.numAdditionals
        com.sun.jndi.dns.Header.recursionDesired

        com.sun.jndi.dsmlv2.SearchResponse.doneRes

        com.sun.jndi.nis.NISMap$GetAllWorker.savedException
        com.sun.jndi.nis.NISMap$NISMAP_ypresp_all.mycount
        com.sun.jndi.internal.onc.rpc.ReadThread.waiting