Name: rmT116609 Date: 04/01/2004


FULL PRODUCT VERSION :
java version "1.4.2_03"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_03-b02)
Java HotSpot(TM) Client VM (build 1.4.2_03-b02, mixed mode)

ADDITIONAL OS VERSION INFORMATION :
Microsoft Windows 2000 [Version 5.00.2195]

A DESCRIPTION OF THE PROBLEM :
In the class javax.swing.filechooser.FileSystemView, the method getSystemIcon() shows all the proper icons, it distorts some of them. Icons for files and directories are slightly enlarged, then clipped to their original size. As a result, the bottoms and right sides are cut off, and they look terrible.


STEPS TO FOLLOW TO REPRODUCE THE PROBLEM :
Run the test program. Expand the tree to view the folders, and compare the image with that of the Windows File Explorer. (In the Windows File Explorer, it's most useful to go the the View menu, Explorer Bar submenu, and turn on "Folders." Then go to the View menu and select "List")


EXPECTED VERSUS ACTUAL BEHAVIOR :
EXPECTED -
The icons in the test program's window should match those in the Windows File Explorer. Windows has two sizes of icons, which can be selected in the "View" menu. I would expect the FileSystemView icons to match the small versions of the Windows icons. Some of them do, but not all of them. (Allowing the user to choose the larger icons is a separate issue, which means changing the API.)

ACTUAL -
The ordinary folder and file icons appear too large, and consequently get clipped. This happens with files, ordinary folders, and with folders that have a special icon, such as "My Archives" and "My Pictures." The size of the icons matches the size of the Windows small icons, so I would expect the image to do so, too. Icons that show up correctly are those for special objects such as volumes, My Computer, and My Network Places. The icons that appear too large don't match either the Windows small icons or the large ones.


REPRODUCIBILITY :
This bug can be reproduced always.

---------- BEGIN SOURCE ----------
import java.awt.*;
import java.io.File;
import java.io.FileFilter;
import java.util.Comparator;
import java.util.Arrays;
import java.util.Enumeration;
import java.util.ArrayList;
import java.util.List;
import javax.swing.*;
import javax.swing.event.TreeSelectionListener;
import javax.swing.event.TreeSelectionEvent;
import javax.swing.filechooser.FileSystemView;
import javax.swing.tree.*;

public class FileSystemIcon extends JPanel
{
  private static JFrame mf;
  private JTree mTree;
  private DefaultTreeModel mModel;
  private JList mFileView;

  public static void main(String[] args)
  {
    try
    {
      UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
    }
    catch (Exception err)
    {
      err.printStackTrace();
    }
    mf=new JFrame("File System Icon Bug");
    mf.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    mf.setBounds(200, 20, 500, 400);
    mf.getContentPane().add(new FileSystemIcon());
    mf.show();
  }

  FileSystemIcon()
  {
    super(new BorderLayout());
    File[] roots=FileSystemView.getFileSystemView().getRoots();
    FileRow root=new FileRow(roots);
    mModel=new DefaultTreeModel(root);
    mTree=new JTree(mModel);
    mTree.setEditable(false);
    mTree.setRootVisible(false);
    mTree.setCellRenderer(new FileTreeRenderer());
    mTree.getSelectionModel().setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
    JScrollPane scr=new JScrollPane(mTree);
    JSplitPane split=new JSplitPane(JSplitPane.HORIZONTAL_SPLIT);
    split.setLeftComponent(scr);

    mFileView=new JList();
    JScrollPane lstScr=new JScrollPane(mFileView);
    split.setRightComponent(lstScr);
    TreeSelectionListener tEar=new TreeSelectionListener()
    {
      public void valueChanged(TreeSelectionEvent e)
      {
        FileRow fr=(FileRow) e.getNewLeadSelectionPath().getLastPathComponent();
        File[] contents=fr.getFile().listFiles();
        mFileView.setListData(contents);
      }
    };
    mTree.addTreeSelectionListener(tEar);
    mFileView.setCellRenderer(new FileListRenderer());
    add(split, BorderLayout.CENTER);
  }

  private static boolean isDirectory(File fl)
  {
    FileSystemView fsv=FileSystemView.getFileSystemView();
    if(fl.isDirectory())
      return fsv.isTraversable(fl).booleanValue();
    return fsv.isComputerNode(fl) || fsv.isDrive(fl) || fsv.isFileSystemRoot(fl);
  }

  private class FileRow
    implements
      FileFilter,
      Comparator,
      TreeNode
  {
    private File mDir;
    private String mName;
    private FileRow[] mChildren;
    private FileRow mParent;

    FileRow(File fl, FileRow parent)
    {
      mDir=fl;
      mName=fl.getName();
      mParent=parent;
      if(mName.length()==0) // file roots have no name
        mName=mDir.toString();
    }

    FileRow(File[] roots)
    {
      mName="Root";
      mChildren=new FileRow[roots.length];
      makeChildren(roots);
    }

    public int getChildCount()
    {
      if(mChildren==null)
        makeChildrenFromDir();
      return mChildren.length;
    }

    public TreeNode getChildAt(int index)
    {
      if(mChildren==null)
        makeChildrenFromDir();
      return mChildren[index];
    }

    private File getFile()
    {
      return mDir;
    }

    /**
     * Workaround to bug 4701462
     */
    private File[] filterFiles(File mDir, FileFilter fltr)
    {
      File[] children=mDir.listFiles();
      List passed=new ArrayList();
      for(int ii=0; ii<children.length; ++ii)
        if(fltr.accept(children[ii]))
          passed.add(children[ii]);
      return (File[]) passed.toArray(new File[0]);
    }

    private void makeChildrenFromDir()
    {
      // We don't call listFiles(FileFilter), due to bug 4701462
// File[] kids = mDir.listFiles(this);
      File[] kids=filterFiles(mDir, this);
      if(kids!=null)
      {
        Arrays.sort(kids, this);
        mChildren=new FileRow[kids.length];
        makeChildren(kids);
      }
      else // this happens sometimes, like when the volume doesn't exist (a:)
        mChildren=new FileRow[0];
    }

    private void makeChildren(File[] kids)
    {
      for(int ii=0; ii<kids.length; ++ii)
        mChildren[ii]=new FileRow(kids[ii], this);
    }

    public boolean accept(File fl)
    {
      return isDirectory(fl);
    }

    public int compare(Object o1, Object o2)
    {
      return ((File) o1).compareTo((File) o2);
    }

    public String toString()
    {
      return mName;
    }

    public TreeNode getParent()
    {
      return mParent;
    }

    public int getIndex(TreeNode node)
    {
      for(int ii=0; ii<mChildren.length; ++ii)
        if(mChildren[ii]==node)
          return ii;
      return -1;
    }

    public boolean getAllowsChildren()
    {
      return true;
    }

    public boolean isLeaf()
    {
      return false;
    }

    public Enumeration children()
    {
      Enumeration enum=new Enumeration()
      {
        int ii=0;

        public boolean hasMoreElements()
        {
          return ii<mChildren.length;
        }

        public Object nextElement()
        {
          return mChildren[ii++];
        }
      };
      return enum;
    }
  }

  private class FileListRenderer extends DefaultListCellRenderer
  {
    public Component getListCellRendererComponent(
            JList list,
            Object value,
            int index,
            boolean isSelected,
            boolean cellHasFocus)
    {
      Component cmp=super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
      Icon sysIcon=FileSystemView.getFileSystemView().getSystemIcon((File) value);
      ((JLabel) cmp).setIcon(sysIcon);
      return cmp;
    }
  }

  private class FileTreeRenderer extends DefaultTreeCellRenderer
  {
    public Component getTreeCellRendererComponent(JTree tree, Object value,
                                                  boolean sel,
                                                  boolean expanded,
                                                  boolean leaf, int row,
                                                  boolean hasFocus)
    {
      File fl=((FileRow) value).getFile();
      String name=FileSystemView.getFileSystemView().getSystemDisplayName(fl);
      Component cmp=super.getTreeCellRendererComponent(tree, name, sel, expanded, leaf, row, hasFocus);
      JLabel jc=(JLabel) cmp;
      Icon fileIcon=FileSystemView.getFileSystemView().getSystemIcon(fl);
      jc.setIcon(fileIcon);
      return jc;
    }
  }
}

---------- END SOURCE ----------
(Incident Review ID: 245233)
======================================================================</TEXTAREA>
</TD>
                    </TR>
                    <TR>
                      <TD colspan="2" bgcolor="#BFBFBF"> </TD>
                    </TR>

<a name="comments"></a>
                    <!-- COMMENTS -->
                    <TR>
                      <TD bgcolor="#BFBFBF" align="left" valign="bottom" height="24">
<img src="/bugz/images/dot.gif" width="10">Comments
</TD>
                      <TD bgcolor="#BFBFBF" align="left" valign="bottom" height="24">
<!-- BEGIN:TBR Mohan
  <A href="javascript:doDateStampSubmit(document.editbug_general, 'comments');"><font size="-1">[ Date Stamp ]</font></A>
<img src="/bugz/images/dot.gif" width="18">
END:TBR -->
<A href="javascript:doFullPageSubmit(document.editbug_general, 'comments');"><font size="-1">[ Full Page ]</font></A>
<img src="/bugz/images/dot.gif" width="22">
<FONT size="-1" color="darkblue">--- Enter SUN Proprietary data here ---</FONT>
</TD>
                    </TR>

                    <TR>
                      <TD bgcolor="#BFBFBF" colspan="2" nowrap align="left">
<img src="/bugz/images/dot.gif" width="5">
                        <TEXTAREA rows="6" cols="95" wrap="virtual" name="comments" align="left" bgcolor="white">

Name: rmT116609 Date: 04/01/2004


(company - Self , email - ###@###.###)
======================================================================
###@###.### 2004-09-07