Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-5073521

TableSorter.java should us JTableHeader.columnAtPoint()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 6u15
    • 5.0
    • docs
    • a
    • x86
    • windows_xp
    • Not verified


      Name: gm110360 Date: 07/13/2004


      FULL PRODUCT VERSION :
      All Versions, even I test it in JDK 1.5 beta 2

      ADDITIONAL OS VERSION INFORMATION :
      All windows platforms.

      A DESCRIPTION OF THE PROBLEM :
      This can be easily reproduced using the samples from
      http://java.sun.com/docs/books/tutorial/uiswing/components/table.html#sorting
      Running the TableSorterDemo.java sample with just one change which is setting the orientation to "ComponentOrientation.RIGHT_TO_LEFT" breaks the sorting.

      STEPS TO FOLLOW TO REPRODUCE THE PROBLEM :
      in your table example which deployed with JDK,
      the bug when change the Component Orientation to Right to left ,
      and Resizing the table header then , the sorting action is throws in wrong way.

      EXPECTED VERSUS ACTUAL BEHAVIOR :
      EXPECTED -
      Correct sorting

      ACTUAL -
      bug in Table header , I suggest that table header should be like cells
      in Editor , this is the correct way only.
      Am realy ask sun , why there is no Editor for Table Header ,
      this is why the hug bug released.
      JTable header render not enough.


      ERROR MESSAGES/STACK TRACES THAT OCCUR :
      no Error message , but Error in GUI .

      REPRODUCIBILITY :
      This bug can be reproduced always.

      ---------- BEGIN SOURCE ----------
      Modified TableSorterDemo.java

      /*
       * TableSorterDemo.java is a 1.4 application that requires this file:
       * TableSorter.java
       */

      import javax.swing.JFrame;
      import javax.swing.JPanel;
      import javax.swing.JScrollPane;
      import javax.swing.JTable;
      import javax.swing.table.AbstractTableModel;
      import java.awt.Dimension;
      import java.awt.GridLayout;
      import java.awt.*;

      /**
       * TableSorterDemo is like TableDemo, except that it
       * inserts a custom model -- a sorter -- between the table
       * and its data model. It also has column tool tips.
       */
      public class TableSorterDemo extends JPanel {
          private boolean DEBUG = false;

          public TableSorterDemo() {
              super(new GridLayout(1,0));

              TableSorter sorter = new TableSorter(new MyTableModel()); //ADDED THIS
              //JTable table = new JTable(new MyTableModel()); //OLD
              JTable table = new JTable(sorter); //NEW
              table.applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
              sorter.setTableHeader(table.getTableHeader()); //ADDED THIS
              table.setPreferredScrollableViewportSize(new Dimension(500, 70));
              

              //Set up tool tips for column headers.
              table.getTableHeader().setToolTipText(
                      "Click to specify sorting; Control-Click to specify secondary sorting");

              //Create the scroll pane and add the table to it.
              JScrollPane scrollPane = new JScrollPane(table);

              //Add the scroll pane to this panel.
              add(scrollPane);
          }

          class MyTableModel extends AbstractTableModel {
              private String[] columnNames = {"First Name",
                                              "Last Name",
                                              "Sport",
                                              "# of Years",
                                              "Vegetarian"};
              private Object[][] data = {
                  {"Mary", "Campione",
                   "Snowboarding", new Integer(5), new Boolean(false)},
                  {"Alison", "Huml",
                   "Rowing", new Integer(3), new Boolean(true)},
                  {"Kathy", "Walrath",
                   "Knitting", new Integer(2), new Boolean(false)},
                  {"Sharon", "Zakhour",
                   "Speed reading", new Integer(20), new Boolean(true)},
                  {"Philip", "Milne",
                   "Pool", new Integer(10), new Boolean(false)}
              };

              public int getColumnCount() {
                  return columnNames.length;
              }

              public int getRowCount() {
                  return data.length;
              }

              public String getColumnName(int col) {
                  return columnNames[col];
              }

              public Object getValueAt(int row, int col) {
                  return data[row][col];
              }

              /*
               * JTable uses this method to determine the default renderer/
               * editor for each cell. If we didn't implement this method,
               * then the last column would contain text ("true"/"false"),
               * rather than a check box.
               */
              public Class getColumnClass(int c) {
                  return getValueAt(0, c).getClass();
              }

              /*
               * Don't need to implement this method unless your table's
               * editable.
               */
              public boolean isCellEditable(int row, int col) {
                  //Note that the data/cell address is constant,
                  //no matter where the cell appears onscreen.
                  if (col < 2) {
                      return false;
                  } else {
                      return true;
                  }
              }

              /*
               * Don't need to implement this method unless your table's
               * data can change.
               */
              public void setValueAt(Object value, int row, int col) {
                  if (DEBUG) {
                      System.out.println("Setting value at " + row + "," + col
                                         + " to " + value
                                         + " (an instance of "
                                         + value.getClass() + ")");
                  }

                  data[row][col] = value;
                  fireTableCellUpdated(row, col);

                  if (DEBUG) {
                      System.out.println("New value of data:");
                      printDebugData();
                  }
              }

              private void printDebugData() {
                  int numRows = getRowCount();
                  int numCols = getColumnCount();

                  for (int i=0; i < numRows; i++) {
                      System.out.print(" row " + i + ":");
                      for (int j=0; j < numCols; j++) {
                          System.out.print(" " + data[i][j]);
                      }
                      System.out.println();
                  }
                  System.out.println("--------------------------");
              }
          }

          /**
           * Create the GUI and show it. For thread safety,
           * this method should be invoked from the
           * event-dispatching thread.
           */
          private static void createAndShowGUI() {
              //Make sure we have nice window decorations.
              JFrame.setDefaultLookAndFeelDecorated(true);

              //Create and set up the window.
              JFrame frame = new JFrame("TableSorterDemo");
              frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

              //Create and set up the content pane.
              TableSorterDemo newContentPane = new TableSorterDemo();
              newContentPane.setOpaque(true); //content panes must be opaque
              frame.setContentPane(newContentPane);

              //Display the window.
              frame.pack();
              frame.setVisible(true);
          }

          public static void main(String[] args) {
              //Schedule a job for the event-dispatching thread:
              //creating and showing this application's GUI.
              javax.swing.SwingUtilities.invokeLater(new Runnable() {
                  public void run() {
                      createAndShowGUI();
                  }
              });
          }
      }


      You will need TableSorter.java which is available at http://java.sun.com/docs/books/tutorial/uiswing/components/example-1dot4/TableSorter.java

      ---------- END SOURCE ----------

      CUSTOMER SUBMITTED WORKAROUND :
      I like Java , and work with it when JDK 1.2.0 released. but I know simply JDK 1.0 - JDK 1.7
      am always download each new version , but realy the best work is JDK 1.5 , but still I want Java to be more improved. JDK 1.5 is just joke for enhancement GUI speed , but you have to know that Java in proccessing is still to much slow.
      I developed Compression utility that can compress zip format from 2% to 10% but the problem it tack too much time, ecpicaily in java processing.
      (Incident Review ID: 281482)
      ======================================================================

            sharonz Sharon Zakhour (Inactive)
            gmanwanisunw Girish Manwani (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: