-
Enhancement
-
Resolution: Won't Fix
-
P4
-
None
-
5.0
-
x86
-
windows_xp
A DESCRIPTION OF THE REQUEST :
The underlying classes used for keyboard decoding in Swing systems, InputMap and ActionMap, use Object as their key. Conventionally, the Object has always been a String representing the name, in the programmers space of the action .
The AbstractAction enforces this by demanding a String, not an Object, in its constructor. Pre Jave 1.5, this was a sensible constring
The addition of the Enum feature in Java 1.5 adds the option of using an Enum instead of a String, which would enhance type-checking in this context. If no string were provided, the string for the Action would be drived from the Enum, but a string could be provided in addition to the enum.
JUSTIFICATION :
1. Better type safety within the Keyboard processing system. Inexperience programmers who type the strings "in line" will not be able to do so. Expereienced programmers using string constants will not be able to accidentally alias onto other predefined strings from the same problem domain.
2. An extra option would be to create EnumInputMap and EnumActionMap based on the new high-performans EnumMap. This would increase performance of Swing, which has been (rightly or wrongly), criticised.
3. Better localisation, because of a weaker tie between the action and the string that represents it.
###@###.### 2005-1-31 22:23:14 GMT
The underlying classes used for keyboard decoding in Swing systems, InputMap and ActionMap, use Object as their key. Conventionally, the Object has always been a String representing the name, in the programmers space of the action .
The AbstractAction enforces this by demanding a String, not an Object, in its constructor. Pre Jave 1.5, this was a sensible constring
The addition of the Enum feature in Java 1.5 adds the option of using an Enum instead of a String, which would enhance type-checking in this context. If no string were provided, the string for the Action would be drived from the Enum, but a string could be provided in addition to the enum.
JUSTIFICATION :
1. Better type safety within the Keyboard processing system. Inexperience programmers who type the strings "in line" will not be able to do so. Expereienced programmers using string constants will not be able to accidentally alias onto other predefined strings from the same problem domain.
2. An extra option would be to create EnumInputMap and EnumActionMap based on the new high-performans EnumMap. This would increase performance of Swing, which has been (rightly or wrongly), criticised.
3. Better localisation, because of a weaker tie between the action and the string that represents it.
###@###.### 2005-1-31 22:23:14 GMT