Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6286732

Cleanup in GTK code

XMLWordPrintable

    • b48
    • generic
    • generic

      Comments from ###@###.###:

      GTKPainter.java:
      Is
      > 521 g.setColor(context.getStyle().getColor(context,
      > 522 GTKColorType.BACKGROUND));
      > 523 g.fillRect(x, y, w, h);
      Necessary? Shouldn't this have been done by Synth?

      GTKCachingPainter.java:
      > 932 public void paintMenuArrowIcon(Graphics g, int w, int h) {
      I think this needs to be parameterized around the component orientation. By that I mean when you call paint for this you should pass in the component orientation.

      > 995 public void paintToolBarHandleIcon(Graphics g, int w, int h) {
      And this needs to be parameterized on toolbar orientation.

      GTKIconFactory.java:
      > 48 private static Map<String, DelegatingIcon> iconsPool =
      > 49 new HashMap<String, DelegatingIcon>() {
      Could you use Collections.synchronizedMap for this?

      ###@###.### 2005-06-16 15:06:10 GMT

            peterz Peter Zhelezniakov
            peterz Peter Zhelezniakov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: