Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6518378

install build warnings on solaris for rt.jar reordering and SecretKey

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: P4 P4
    • None
    • 7
    • security-libs
    • None

      Copying from email to ###@###.###:

      See below. You introduced an build warning back in Aug of 05, do you recall why you added javax/crypto/SecretKey to the make/tools/share/classlist.solaris file?

      ###@###.### wrote:
      > ###@###.### wrote:
      >>>
      >>> Included file javax/crypto/SecretKey.class missing, skipping.
      >>
      >> Hmm, what does this mean? We have pre-built
      >> JCE jar files. Why SecretKey.class gets called out?
      >
      > That looks like the JAR reordering for rt.jar that is used to improve startup time.
      >
      > I believe that reordering file is semi-automatically generated and probably someone forgot to exclude files that are not actually in rt.jar. I don't think the message is indicative of an actual problem.

      To expand a bit, the javax.crypto classes are in the <java-home>/lib/jce.jar file, not rt.jar.

      Valerie later wrote:

      > make/tools/sharing/classlist.solaris file added SecretKey class during
      > the following revision.
      >
      > D 1.7 05/08/30 18:50:21 bchristi 8 7 01379/00829/01540
      > 6291925. Classlist updated for b49, using Dmitri's script
      >
      > Maybe Dmitri's script does not check to see if the classes did reside in
      > rt.jar or not.
      > If this is the cause, then maybe updating this particular file would
      > resolve the warning.

      Valerie pegged it. I came to the same conclusion independently before O saw her email. SecretKey is definitely mentioned in that file, and shouldn't be there. The build appends a checksum to the end of the static classlist file (which is copied from the classlist.solaris), and then calls the reordering.

      IMO, simply taking SecretKey out is the right course of action.

      More info from the original post:

      Jim Holmlund wrote On 01/26/07 14:28,:

      > >I built 'images' and got these warnings:
      > >
      > >
      > > /net/mmm/export/home/jjh/ws/7/j2se/build/solaris-sparc/bin/java -client -Xmx512m -Xms256m -classpath /net/mmm/export/home/jjh/ws/7/j2se/build/solaris-sparc/tmp/reorder JarReorder \
      > > -o /net/mmm/export/home/jjh/ws/7/j2se/build/solaris-sparc/tmp/reorder/file_list.temp /net/mmm/export/home/jjh/ws/7/j2se/build/solaris-sparc/lib/classlist /net/mmm/export/home/jjh/ws/7/j2se/build/solaris-sparc/tmp/not_rt_jar.list .
      > >Included file java/util/logging/LogManager$6.class missing, skipping.
      > >Included file javax/crypto/SecretKey.class missing, skipping.
      > >Included file sun/nio/cs/ext/GBK$Decoder.class missing, skipping.
      > >Included file sun/nio/cs/ext/GBK.class missing, skipping.
      > >Included file sun/nio/cs/ext/MS950$Decoder.class missing, skipping.
      > >Included file sun/nio/cs/ext/MS950.class missing, skipping.
      > >Included file sun/nio/cs/ext/DoubleByteDecoder.class missing, skipping.
      > >Included file sun/nio/cs/ext/EUC_KR$Decoder.class missing, skipping.
      > >Included file sun/nio/cs/ext/EUC_KR.class missing, skipping.
      > >Included file sun/nio/cs/ext/ExtendedCharsets.class missing, skipping.
      > >
      > >- jjh
      > >
      > >

            wetmore Bradford Wetmore
            wetmore Bradford Wetmore
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: