Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6704165

JDK_DEBUG_IMAGE_DIR used in jdk/make/common/Release.gmk but not defined

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 7
    • 7
    • infrastructure
    • None
    • 7
    • b29
    • generic
    • generic

      ###@###.### writes:

      The only reference to JDK_DEBUG_IMAGE_DIR
      in the jdk workspace is

      ./make/common/Release.gmk:1239: $(RM) -r $(JDK_DEBUG_IMAGE_DIR)

      This variable is defined nowhere.

      As a result, "make images-clobber" runs the command

      rm -f -r

      This is Mostly Harmless, but what would happen if a user happened to
      have defined an environment variable

      JDK_DEBUG_IMAGE_DIR=/

      so I consider this a P2 bug.

      Just remove that line from Release.gmk.

      For bonus points, write a script to find all never-defined MAKE variables
      in all the JDK makefiles.

      # HG changeset patch
      # User martin
      # Date 1211056134 25200
      # Node ID 9149e388e6e353da275887a0e6b4ae5ef63b4689
      # Parent 1483094a7c17de9c594d51e0f0785d24e3858392
      [mq]: JDK_DEBUG_IMAGE_DIR.patch

      diff --git a/make/common/Release.gmk b/make/common/Release.gmk
      --- a/make/common/Release.gmk
      +++ b/make/common/Release.gmk
      @@ -1236,7 +1236,6 @@ ifeq ($(PLATFORM), windows)
        $(RM) $(TEMPDIR)/rebase.input
       endif
        $(RM) -r $(JDK_IMAGE_DIR)
      - $(RM) -r $(JDK_DEBUG_IMAGE_DIR)
        $(RM) -r $(JRE_IMAGE_DIR)

       images images-clobber::

            tbell Tim Bell
            tbell Tim Bell
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: