-
Sub-task
-
Resolution: Fixed
-
P4
-
6u10
-
b05
-
x86
-
windows
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8073586 | 9 | Daniil Titov | P4 | Resolved | Fixed | b54 |
JDK-8082260 | emb-9 | Daniil Titov | P4 | Resolved | Fixed | b54 |
JDK-8086340 | 8u65 | Daniil Titov | P4 | Resolved | Fixed | b01 |
JDK-8137427 | emb-8u65 | Unassigned | P4 | Resolved | Fixed | b01 |
JDK-8076816 | emb-8u60 | Daniil Titov | P4 | Resolved | Fixed | team |
Code cleaning can be in several areas for plugin2 as per Findbugs result from security audit:
1) sun.plugin2.applet.NativeLibraryBundle's static initializer, constructor, copyFiles(), deleteOldDirs(), deleteRecursively() and finalize() ignore exceptional returned values from File.mkdirs(), File.delete()
2) Method name start with non lower case:
- sun.plugin2.main.server.IExplorerPlugin.CreateControlWindow(), FinalRelease(), InPlaceActivate(), InPlaceDeactivate(), OnDestroy(), OnDraw(), OnFrameWindowActivate(), OnSetFocus(), SetClientSite(), SetObjectRects(),
- sun.plugin2.os.windows.Windows: CloseHandle(), ConnectNamedPipe(), CreateEventA(), CreateFileA(), CreateNamedPipeA(), DisconnectNamedPipe(), FlashWindowEx(), GetCurrentProcessId(), GetLastError(), GetVersionExA(), MessageBeep(), OpenEventA(), ReadFile(), ResetEvent(), SetEvent(), WaitForSingleObject(), WriteFile()
3) Finalizer null fields (not aid in garbage collection)
- sun.plugin2.applet.Applet2AudioClipFactory.finalize()
4) Dead local store (assigns a class literal to a variable but never uses it):
- sun.plugin2.main.client.PluginMain.run()
- sun.plugin2.applet.Applet2Environment's configProps
- sun.plugin2.applet.DragHelper.createCloseButton()'s centerX a& centerY
- sun.plugin2.applet.JNLP2Manager.prepareLaunchFile()'s secureArgs
- sun.plguin2.main.server.JVMManger.setAppletSize()'s size
5) Dodgy: Exception caught when it is not thrown:
- sun.plugin2.applet.Applet2ClassLoader.getResourceAsStream(), resourceExists()
- sun.plugin2.applet.Plugin2ClassLoader.getDefineClassMethod()
- sun.plugin2.applet.Plguin2ClassLoader.getUCPField()
- sun.plugin2.main.client.LiveConnectSupport.doObjectOp()
- sun.plugin2.main.client.ModalityHelper.reactivate()
- sun.plugin2.main.server.JVMInstance.$HeartbeatThread.run() ** not valid
- sun.plugin2.main.server.JVMInstance.$WorkerThread.run() ** not valid
1) sun.plugin2.applet.NativeLibraryBundle's static initializer, constructor, copyFiles(), deleteOldDirs(), deleteRecursively() and finalize() ignore exceptional returned values from File.mkdirs(), File.delete()
2) Method name start with non lower case:
- sun.plugin2.main.server.IExplorerPlugin.CreateControlWindow(), FinalRelease(), InPlaceActivate(), InPlaceDeactivate(), OnDestroy(), OnDraw(), OnFrameWindowActivate(), OnSetFocus(), SetClientSite(), SetObjectRects(),
- sun.plugin2.os.windows.Windows: CloseHandle(), ConnectNamedPipe(), CreateEventA(), CreateFileA(), CreateNamedPipeA(), DisconnectNamedPipe(), FlashWindowEx(), GetCurrentProcessId(), GetLastError(), GetVersionExA(), MessageBeep(), OpenEventA(), ReadFile(), ResetEvent(), SetEvent(), WaitForSingleObject(), WriteFile()
3) Finalizer null fields (not aid in garbage collection)
- sun.plugin2.applet.Applet2AudioClipFactory.finalize()
4) Dead local store (assigns a class literal to a variable but never uses it):
- sun.plugin2.main.client.PluginMain.run()
- sun.plugin2.applet.Applet2Environment's configProps
- sun.plugin2.applet.DragHelper.createCloseButton()'s centerX a& centerY
- sun.plugin2.applet.JNLP2Manager.prepareLaunchFile()'s secureArgs
- sun.plguin2.main.server.JVMManger.setAppletSize()'s size
5) Dodgy: Exception caught when it is not thrown:
- sun.plugin2.applet.Applet2ClassLoader.getResourceAsStream(), resourceExists()
- sun.plugin2.applet.Plugin2ClassLoader.getDefineClassMethod()
- sun.plugin2.applet.Plguin2ClassLoader.getUCPField()
- sun.plugin2.main.client.LiveConnectSupport.doObjectOp()
- sun.plugin2.main.client.ModalityHelper.reactivate()
- sun.plugin2.main.server.JVMInstance.$HeartbeatThread.run() ** not valid
- sun.plugin2.main.server.JVMInstance.$WorkerThread.run() ** not valid
- backported by
-
JDK-8073586 Plugin2: simple code clean-up as per Findbugs' result from security audit
-
- Resolved
-
-
JDK-8076816 Plugin2: simple code clean-up as per Findbugs' result from security audit
-
- Resolved
-
-
JDK-8082260 Plugin2: simple code clean-up as per Findbugs' result from security audit
-
- Resolved
-
-
JDK-8086340 Plugin2: simple code clean-up as per Findbugs' result from security audit
-
- Resolved
-
-
JDK-8137427 Plugin2: simple code clean-up as per Findbugs' result from security audit
-
- Resolved
-