Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6741378

Bad tab behavior in JFileChooser using Windows L&F

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: P4 P4
    • None
    • 5.0
    • client-libs

      FULL PRODUCT VERSION :
      java version "1.5.0_10"
      Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_10-b03)
      Java HotSpot(TM) Client VM (build 1.5.0_10-b03, mixed mode, sharing)

      ADDITIONAL OS VERSION INFORMATION :
      Windows XP with SP2
      Microsoft Windows XP [Version 5.1.2600]

      A DESCRIPTION OF THE PROBLEM :
      When running a JFileChooser and using the Windows XP L&F, it becomes non-obvious which control is selected after tabbing through a few of the controls.

      STEPS TO FOLLOW TO REPRODUCE THE PROBLEM :
      Modify the FileChooserDemo.java example to use system L&F on Windows XP.
      Launch the modified FileChooserDemo.
      Click on "Save a File"
      Tab 5 times.


      EXPECTED VERSUS ACTUAL BEHAVIOR :
      EXPECTED -
      The up arrow w/ folder should show selection, but it doesn't.
      ACTUAL -
      There is no indication that the up icon is selected, however pressing the space bar does do the proper action.

      REPRODUCIBILITY :
      This bug can be reproduced always.

      ---------- BEGIN SOURCE ----------
      /*
       * Copyright (c) 1995 - 2008 Sun Microsystems, Inc. All rights reserved.
       *
       * Redistribution and use in source and binary forms, with or without
       * modification, are permitted provided that the following conditions
       * are met:
       *
       * - Redistributions of source code must retain the above copyright
       * notice, this list of conditions and the following disclaimer.
       *
       * - Redistributions in binary form must reproduce the above copyright
       * notice, this list of conditions and the following disclaimer in the
       * documentation and/or other materials provided with the distribution.
       *
       * - Neither the name of Sun Microsystems nor the names of its
       * contributors may be used to endorse or promote products derived
       * from this software without specific prior written permission.
       *
       * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
       * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
       * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
       * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
       * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
       * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
       * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
       * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
       * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
       * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
       * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       */

      package components;

      import java.io.*;
      import java.awt.*;
      import java.awt.event.*;
      import javax.swing.*;
      import javax.swing.SwingUtilities;
      import javax.swing.filechooser.*;

      /*
       * FileChooserDemo.java uses these files:
       * images/Open16.gif
       * images/Save16.gif
       */
      public class FileChooserDemo extends JPanel
                                   implements ActionListener {
          static private final String newline = "\n";
          JButton openButton, saveButton;
          JTextArea log;
          JFileChooser fc;

          public FileChooserDemo() {
              super(new BorderLayout());

              //Create the log first, because the action listeners
              //need to refer to it.
              log = new JTextArea(5,20);
              log.setMargin(new Insets(5,5,5,5));
              log.setEditable(false);
              JScrollPane logScrollPane = new JScrollPane(log);

              //Create a file chooser
              fc = new JFileChooser();

              //Uncomment one of the following lines to try a different
              //file selection mode. The first allows just directories
              //to be selected (and, at least in the Java look and feel,
              //shown). The second allows both files and directories
              //to be selected. If you leave these lines commented out,
              //then the default mode (FILES_ONLY) will be used.
              //
              //fc.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
              //fc.setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);

              //Create the open button. We use the image from the JLF
              //Graphics Repository (but we extracted it from the jar).
              openButton = new JButton("Open a File...",
                                       createImageIcon("images/Open16.gif"));
              openButton.addActionListener(this);

              //Create the save button. We use the image from the JLF
              //Graphics Repository (but we extracted it from the jar).
              saveButton = new JButton("Save a File...",
                                       createImageIcon("images/Save16.gif"));
              saveButton.addActionListener(this);

              //For layout purposes, put the buttons in a separate panel
              JPanel buttonPanel = new JPanel(); //use FlowLayout
              buttonPanel.add(openButton);
              buttonPanel.add(saveButton);

              //Add the buttons and the log to this panel.
              add(buttonPanel, BorderLayout.PAGE_START);
              add(logScrollPane, BorderLayout.CENTER);
          }

          public void actionPerformed(ActionEvent e) {

              //Handle open button action.
              if (e.getSource() == openButton) {
                  int returnVal = fc.showOpenDialog(FileChooserDemo.this);

                  if (returnVal == JFileChooser.APPROVE_OPTION) {
                      File file = fc.getSelectedFile();
                      //This is where a real application would open the file.
                      log.append("Opening: " + file.getName() + "." + newline);
                  } else {
                      log.append("Open command cancelled by user." + newline);
                  }
                  log.setCaretPosition(log.getDocument().getLength());

              //Handle save button action.
              } else if (e.getSource() == saveButton) {
                  int returnVal = fc.showSaveDialog(FileChooserDemo.this);
                  if (returnVal == JFileChooser.APPROVE_OPTION) {
                      File file = fc.getSelectedFile();
                      //This is where a real application would save the file.
                      log.append("Saving: " + file.getName() + "." + newline);
                  } else {
                      log.append("Save command cancelled by user." + newline);
                  }
                  log.setCaretPosition(log.getDocument().getLength());
              }
          }

          /** Returns an ImageIcon, or null if the path was invalid. */
          protected static ImageIcon createImageIcon(String path) {
              java.net.URL imgURL = FileChooserDemo.class.getResource(path);
              if (imgURL != null) {
                  return new ImageIcon(imgURL);
              } else {
                  System.err.println("Couldn't find file: " + path);
                  return null;
              }
          }

          /**
           * Create the GUI and show it. For thread safety,
           * this method should be invoked from the
           * event dispatch thread.
           */
          private static void createAndShowGUI() {
              //Create and set up the window.
              JFrame frame = new JFrame("FileChooserDemo");
              frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

              //Add content to the window.
              frame.add(new FileChooserDemo());

              //Display the window.
              frame.pack();
              frame.setVisible(true);
          }

          public static void main(String[] args) {
              //Schedule a job for the event dispatch thread:
              //creating and showing this application's GUI.
              SwingUtilities.invokeLater(new Runnable() {
                  public void run() {
                      //Turn off metal's use of bold fonts
                      //UIManager.put("swing.boldMetal", Boolean.FALSE);
                      try {
                          UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
                      } catch (ClassNotFoundException e) {
                          e.printStackTrace(); //To change body of catch statement use File | Settings | File Templates.
                      } catch (InstantiationException e) {
                          e.printStackTrace(); //To change body of catch statement use File | Settings | File Templates.
                      } catch (IllegalAccessException e) {
                          e.printStackTrace(); //To change body of catch statement use File | Settings | File Templates.
                      } catch (UnsupportedLookAndFeelException e) {
                          e.printStackTrace(); //To change body of catch statement use File | Settings | File Templates.
                      }
                      createAndShowGUI();
                  }
              });
          }
      }

      ---------- END SOURCE ----------

            rupashka Pavel Porvatov (Inactive)
            ndcosta Nelson Dcosta (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: