Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6899049

G1: Clean up code in ptrQueue.[ch]pp and ptrQueue.inline.hpp

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P5 P5
    • 9
    • 7
    • hotspot
    • gc
    • b94
    • generic
    • generic

        During the code reviews for 6895788 a comment was made about the cleanliness of the current code in ptrQueue.hpp, ptrQueue.cpp, and ptrQueue.hpp.

        There are:
          * duplicated service routines (defined in the PtrQueue class and static within the .cpp file).

          * unused routines.

          * Loops that have strides other than 1 (which can be rewritten).

        We also allocate an additional data structure that has one entry for each completed buffer (CompletedBufferNode) that is unnecessary. The completed buffers could be chained in some other way.

        It would be desirable to clean up this code.

              kbarrett Kim Barrett
              johnc John Cuthbertson
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved:
                Imported:
                Indexed: