P5 | Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8316278 | Jianye Sun | P4 | Closed | Other |
During the code reviews for 6895788 a comment was made about the cleanliness of the current code in ptrQueue.hpp, ptrQueue.cpp, and ptrQueue.hpp.
There are:
* duplicated service routines (defined in the PtrQueue class and static within the .cpp file).
* unused routines.
* Loops that have strides other than 1 (which can be rewritten).
We also allocate an additional data structure that has one entry for each completed buffer (CompletedBufferNode) that is unnecessary. The completed buffers could be chained in some other way.
It would be desirable to clean up this code.
There are:
* duplicated service routines (defined in the PtrQueue class and static within the .cpp file).
* unused routines.
* Loops that have strides other than 1 (which can be rewritten).
We also allocate an additional data structure that has one entry for each completed buffer (CompletedBufferNode) that is unnecessary. The completed buffers could be chained in some other way.
It would be desirable to clean up this code.
- backported by
-
JDK-8316278 Fix the indexing method of PtrQueue's buf when a large integer value overflow as setted by `G1SATBBufferSize`
-
- Closed
-
- links to
-
Review
openjdk/jdk8u-dev/374