Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6941224

Improved stack overflow handling for Zero

    XMLWordPrintable

Details

    • b04
    • generic
    • generic

    Backports

      Description

        Gary Benson wrote:

        Hi all,

        I recently started adding stack overflow checking to Shark,
        which brought to light a bunch of deficiencies in Zero's
        stack overflow code. Zero had this really odd, look-ahead
        overflow handling which was pretty strange, easily fooled,
        and in retrospect totally unnecessary. I'm pretty sure
        whoever wrote it was an idiot.

        This webrev removes the old overflow detection and replaces
        it with something more straightforward and complete:

          http://cr.openjdk.java.net/~gbenson/zero-stack-overflow-checks/

        Note that a number of calls to Unimplemented have been removed.
        It shouldn't be possible to have an unhandled stack overflow
        error with the new code.

        As a bonus, the new code is mildly faster (about 2%) due to
        the checks being inlined.

        I don't have a bug id for this.

        Cheers,
        Gary

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-2192536 Improved stack overflow handling for Zero

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-2193548 Improved stack overflow handling for Zero

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-2198013 Improved stack overflow handling for Zero

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-2199964 Improved stack overflow handling for Zero

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-6962193 Rebrand some Zero files

            • P3 - Major loss of function.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-6944473 6941224 misses new files

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Activity

              People

                twisti Christian Thalinger
                twisti Christian Thalinger
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: