Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6944822

Fix for 6938627 exposes problem with hard-coded buffer sizes

XMLWordPrintable

    • b01
    • generic
    • generic

        Andreas Kohn reports:

        while reading a bit the hotspot sources I noticed a potential issue with
        the fix for 6938627 (Make temporary directory use property
        java.io.tmpdir when specified) in some places.

        Before the fix the callers of get_temp_directory() could hardcode the
        size of the filename buffer to a small number, but now that
        get_temp_directory() returns a value settable by the user this looks a
        bit dangerous.

        In particular:
        attachListener_linux.cpp:AttachListener::is_init_trigger()
        attachListener_solaris.cpp:AttachListener::is_init_trigger()
          both use a 128 byte buffer

        os_linux.cpp:linux_wrap_code()
          uses a 40 byte buffer.


        Attached patch changes the buffers to PATH_MAX+1 bytes, the same value
        used by other places that call get_temp_directory().

              coleenp Coleen Phillimore
              dholmes David Holmes
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved:
                Imported:
                Indexed: