-
Bug
-
Resolution: Fixed
-
P2
-
6u20
-
b02
-
x86
-
linux
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-2198159 | 7 | Dennis Gu | P2 | Resolved | Fixed | b115 |
In the IPCFactory.java there is an assumption that the IPC arguments cannot have multiple equals characters. On Mac OS X , java.io.tmpdir points to a path that may have an equals character in it. In this case the IPC mechanism is completly broken and Plugin2 dies.
For example the argument to the child can be :
write_pipe_name=/var/folders/5s/bgzw1=tc658d0vqrjrd1s593++++fn/T/.com.sun.deploy.net.socket.-1.4567144119737929337.AF_UNIX
The fix for this problem is as below :
svn diff --depth empty -x -u -x -w 'src/plugin/share/classes/sun/plugin2/ipc/IPCFactory.java'
Index: src/plugin/share/classes/sun/plugin2/ipc/IPCFactory.java
===================================================================
@@ -140,8 +140,14 @@
Map/*<String,String>*/ map = new HashMap/*<String,String>*/();
String[] strs = inputString.split(",");
for (int i = 0; i < strs.length; i++) {
- String[] kv = strs[i].split("=");
- map.put(kv[0], kv[1]);
+ String str = strs[i];
+ int firstEquals = str.indexOf("=");
+ map.put(str.substring(0, firstEquals), str.substring(firstEquals+1, str.length()));
}
return map;
}
For example the argument to the child can be :
write_pipe_name=/var/folders/5s/bgzw1=tc658d0vqrjrd1s593++++fn/T/.com.sun.deploy.net.socket.-1.4567144119737929337.AF_UNIX
The fix for this problem is as below :
svn diff --depth empty -x -u -x -w 'src/plugin/share/classes/sun/plugin2/ipc/IPCFactory.java'
Index: src/plugin/share/classes/sun/plugin2/ipc/IPCFactory.java
===================================================================
@@ -140,8 +140,14 @@
Map/*<String,String>*/ map = new HashMap/*<String,String>*/();
String[] strs = inputString.split(",");
for (int i = 0; i < strs.length; i++) {
- String[] kv = strs[i].split("=");
- map.put(kv[0], kv[1]);
+ String str = strs[i];
+ int firstEquals = str.indexOf("=");
+ map.put(str.substring(0, firstEquals), str.substring(firstEquals+1, str.length()));
}
return map;
}
- backported by
-
JDK-2198159 Plugin2's IPCFactory.java incorrectly parses incoming arguments
-
- Resolved
-