-
Type:
Bug
-
Resolution: Fixed
-
Priority:
P3
-
Affects Version/s: 7-client
-
Component/s: deploy
-
b08
-
x86
-
windows
-
Verified
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-2214771 | 8 | Thomas Ng | P3 | Closed | Fixed | b12 |
when fixing 7068626 - it's noticed that we should refactor unregisgterDeploy in regfx.cpp:
I'd suggest to structure code differently like:
if (checkIfOurBinariesAreRegisteredFroDeploy()) {
doRegularUninstall()
if (hadShadowedJRE()) {
reregisterShadowedJRE();
}
}
For reregister logic we can refactor registerDeploy() to extract function that will register everything given
root directory. Then we can use it for reregister and registerDeploy() to avoid replicating the code
to reconstruct registry keys?
I'd suggest to structure code differently like:
if (checkIfOurBinariesAreRegisteredFroDeploy()) {
doRegularUninstall()
if (hadShadowedJRE()) {
reregisterShadowedJRE();
}
}
For reregister logic we can refactor registerDeploy() to extract function that will register everything given
root directory. Then we can use it for reregister and registerDeploy() to avoid replicating the code
to reconstruct registry keys?
- backported by
-
JDK-2214771 refactor unregister deploy in regfx.cpp
-
- Closed
-