-
Enhancement
-
Resolution: Fixed
-
P4
-
8
-
generic
-
generic
This RFE is related to any improvements of the JDK source code legal headers verification process and the script $ROOT/make/scripts/lic_check.sh
1. Recursion in the script is under question. The arrangement to have the script invoke itself recursively on directories seems remarkably fragile.
2. Text processing is complicated, it's recommended to use a different script language, i.e Java app to benefit of an IDE and Junit tests, or use awk, or perl or python.
3. It would be nice to have a README file in $ROOT/make/templates directory with a warning like "DO NOT MODIFY TEMPLATES IF IT'S NOT APPROVED". Template files should be modified only if any change of the copyright header is approved by legal department. In this case the script to check license headers should be modified accordingly.
1. Recursion in the script is under question. The arrangement to have the script invoke itself recursively on directories seems remarkably fragile.
2. Text processing is complicated, it's recommended to use a different script language, i.e Java app to benefit of an IDE and Junit tests, or use awk, or perl or python.
3. It would be nice to have a README file in $ROOT/make/templates directory with a warning like "DO NOT MODIFY TEMPLATES IF IT'S NOT APPROVED". Template files should be modified only if any change of the copyright header is approved by legal department. In this case the script to check license headers should be modified accordingly.
- relates to
-
JDK-7178241 Basic script for JDK source code legal headers conformance verification
-
- Resolved
-