Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8000592

Improve adlc usability

    XMLWordPrintable

Details

    • b61
    • generic
    • generic

    Backports

      Description

        We did a row of smaller changes to adlc to improve its usability, e.g.

        - Make adlc more stable, especially if parsing faulty .ad files.
        - In some cases raise syntax errors instead of asserting.
        - Write more comments into generated files and beautify format.
        - Make calls to node->format() more stable.
        - Clean up adlc code: warnings, dead code etc.

        Notice that all these changes shouldn't affect the generated code in any way!

        I collected all these and put them into this webrev:

         http://cr.openjdk.java.net/~goetz/webrevs/webrev-adlc_usability/

        We would like to contribute this to the openJDK. Could somebody
        please review the change and push it if it seems useful to you?

        Thanks a lot,
          Goetz.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8000668 Improve adlc usability

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8001736 Improve adlc usability

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8002947 Improve adlc usability

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8002948 Improve adlc usability

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8002949 Improve adlc usability

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8017812 Improve adlc usability

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Activity

              People

                kvn Vladimir Kozlov
                kvn Vladimir Kozlov
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: