Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8001902

build-infra: ListPathsSafely confusing unneccessary and confusing replacements

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • None
    • infrastructure

      The ListPathsSafely sed "compression" scripts (common/makefiles/support/ListPathsSafely-*) contains the following "compressions":
      s|X01|com|g
      s|X02|org|g
      s|X03|sun|g

      SInce replacing "com" with "X01" does not save any space, this just makes command lines harder to read in the log for no good reason. It also threw me completely off when trying to figure out how the macros worked, since I believed that the replacements were there for a reason, which I couldn't for my life figure out.

      We should probably remove these three conversions, and seriously consider if replacing "java" with X04 is worth the loss in readability. (The main gain from the compression function is anyway likely to be the prefix to the source root...)

            Unassigned Unassigned
            ihse Magnus Ihse Bursie
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: