Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8001940

build-infra: HotspotWrapper.gmk does not detect removed files

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • None
    • infrastructure

      If you remove individual files in build/<conf>/hotspot, the HotspotWrapper.gmk does not see the need to trigger a recompile.

      This could be solved by not just having an empty touch file, but by doing like "find build/<conf>/hotspot > build/<conf>/hotspot/.hotspot_marker" and the next time do "find build/<conf>/hotspot > temp-file" and comparing temp-file and .hotspot_marker.

      Not sure if it's worth the effort, but it has been frustrating for me several times that removed files didn't trigger a recompile. It's a bit surprising, and it's an artifact of our wrapper, so I think it should be fixed. Don't know the performance penalty on Windows, though. Might be prohibitive.

            Unassigned Unassigned
            ihse Magnus Ihse Bursie
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: