Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8005818

Shark: fix OSR for non-empty incoming stack

XMLWordPrintable

    • b16
    • generic
    • generic

        http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2012-December/009087.html

        This patch disables on-stack-replacement in Shark when the incoming
        stack-depth is > 0. (This caused a segmentation fault when running
        SpecJVM.)

        http://cr.openjdk.java.net/~rkennke/shark-osr/webrev.00/

        I tried to figure out what to do in that case for a while, until I
        looked at opto which simply bails out, so I decided to do the same. Is
        there anything better that could be done without huge efforts (it seems
        to happen very rarely after all)?

        Ok to go in?

        (I have a bunch of patches coming up for Shark, I was undecided if I
        should post them as one big or several smaller patches, and then found
        that having several unrelated things interleaved in one patch makes it
        really difficult to understand what it does.)

        Regards,
        Roman

              twisti Christian Thalinger (Inactive)
              twisti Christian Thalinger (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: