Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8009558

linked_md.c::dll_build_name can get stuck in an infinite loop

XMLWordPrintable

    • b86
    • Not verified

        This came up in the review of JDK-8009397, but after that fix had been pushed.

        From: "serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com>
        Subject: Re: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket
        Date: 5 mars 2013 20:26:49 CET
        To: Staffan Larsen <staffan.larsen@oracle.com>
        Cc: "serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>, "core-libs-dev@openjdk.java.net" <core-libs-dev@openjdk.java.net>

        Hi Staffan,

        Thank you for this discovery!
        It looks good, but I have a couple of comments.

        It seems, there is one more problem in this code:
          68 /* check for NULL path */
          69 if (p == pathname) {
          70 continue; <== Endless loop if we hit this line
          71 }

        Do we need to do 'pathname++' before continuing at the line #70?
        It is going to be endless loop in cases there is a PATH_SEPARATOR
        at the beginning of paths or two PATH_SEPARATOR's in a row.
        These would be incorrect path lists but the code above is targeting exactly such cases.

              sla Staffan Larsen (Inactive)
              sla Staffan Larsen (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: