Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8017222

jdk8 configure should fail the build if Client.jar cannot be found and either SIGN_FLAG or MAC_SIGN_FLAG is set

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2 P2
    • 8
    • None
    • infrastructure
    • b112
    • Not verified

      jdk8 autoconf should fail the build if Client.jar cannot be found and either SIGN_FLAG or MAC_SIGN_FLAG is set .

      Either of the variables SIGN_FLAG or MAC_SIGN_FLAG being set is a directive to sign the build, and the build is broken without it being signed. This should be a failure and not just a warning

      configure: WARNING: CCSS Client.jar could not be found. Installer will not sign jars.


      In order for signing to work on macosx, MAC_SIGN_FLAG must be set to 1, see:

          install/make/common/Defs-macosx.gmk
          install/make/common/Binaries.gmk
          install/make/installer/bundles/macosx

      Similarly, SIGN_FLAG is used for windows as well, through out install.

      If either is set at the beginning of a build, when configure attempts and cannot find Client.jar, this should be a hard failure, not a warning, since the setting of SIGN_FLAG (or MAC_SIGN_FLAG
      ) is a request for the build to be signed.


      Also in need of clean up is how Client.jar is found in install/make/common/Defs-macosx.gmk, as only $(RE_LOCAL_TOOL_DIR) is used and it is hard coded to /localtools/macosx
      Needs to be changed to how it's done in Defs-windows.gmk

        CCSS_SIGNING_DIR = "/localtools/macosx/"
        ifdef ALT_CCSS_SIGNING_DIR
          CCSS_SIGNING_DIR = $(ALT_CCSS_SIGNING_DIR)
        endif

      Extra credit for normalizing all the "MAC_SIGN_FLAG" definitions to just "SIGN_FLAG", while you're there.

            erikj Erik Joelsson
            katleman David Katleman (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: