Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8020092

os::address_is_in_vm() on Windows can use "GetModuleHandleEx()"

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Won't Fix
    • Icon: P4 P4
    • 10
    • hs25
    • hotspot
    • generic
    • generic

      This issue came up during the review for the following:

          JDK-8015884 runThese crashed with SIGSEGV, hs_err has an error instead
                                 of stacktrace

      Here is Zhengyu's original code review comment and my reply:

      On 7/3/13 7:28 AM, Zhengyu Gu wrote:
      >>
      >> On 7/2/13 7:50 PM, Zhengyu Gu wrote:
      >>>
      >>> One possible enhancement, you can decide if should be done under this bug.
      >>>
      >>> os_windows.cpp
      >>> os::address_is_in_vm(address addr)
      >>>
      >>> I think there is simpler way using Windows API "GetModuleHandleEx() with GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS.
      >>
      > On 7/3/13 7:16 AM, Daniel D. Daugherty wrote:
      >>
      >> My Windows changes in this bug are very minimal and I think I'd
      >> like to keep it that way. However, I will file an RFE for the
      >> suggestion. Would this improvement count as a "starter" bug?
      > Yes, make sense. It is a starter bug.
      >
      > Thanks,
      >
      > -Zhengyu

            Unassigned Unassigned
            dcubed Daniel Daugherty
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: