This issue came up during the review for the following:
JDK-8015884 runThese crashed with SIGSEGV, hs_err has an error instead
of stacktrace
Here is Zhengyu's original code review comment and my reply:
On 7/3/13 7:28 AM, Zhengyu Gu wrote:
>>
>> On 7/2/13 7:50 PM, Zhengyu Gu wrote:
>>>
>>> One possible enhancement, you can decide if should be done under this bug.
>>>
>>> os_windows.cpp
>>> os::address_is_in_vm(address addr)
>>>
>>> I think there is simpler way using Windows API "GetModuleHandleEx() with GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS.
>>
> On 7/3/13 7:16 AM, Daniel D. Daugherty wrote:
>>
>> My Windows changes in this bug are very minimal and I think I'd
>> like to keep it that way. However, I will file an RFE for the
>> suggestion. Would this improvement count as a "starter" bug?
> Yes, make sense. It is a starter bug.
>
> Thanks,
>
> -Zhengyu
JDK-8015884 runThese crashed with SIGSEGV, hs_err has an error instead
of stacktrace
Here is Zhengyu's original code review comment and my reply:
On 7/3/13 7:28 AM, Zhengyu Gu wrote:
>>
>> On 7/2/13 7:50 PM, Zhengyu Gu wrote:
>>>
>>> One possible enhancement, you can decide if should be done under this bug.
>>>
>>> os_windows.cpp
>>> os::address_is_in_vm(address addr)
>>>
>>> I think there is simpler way using Windows API "GetModuleHandleEx() with GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS.
>>
> On 7/3/13 7:16 AM, Daniel D. Daugherty wrote:
>>
>> My Windows changes in this bug are very minimal and I think I'd
>> like to keep it that way. However, I will file an RFE for the
>> suggestion. Would this improvement count as a "starter" bug?
> Yes, make sense. It is a starter bug.
>
> Thanks,
>
> -Zhengyu
- relates to
-
JDK-8020090 os::address_is_in_vm() should guarantee() the base address for libjvm
-
- Closed
-