-
Bug
-
Resolution: Fixed
-
P3
-
9
-
b147
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8287346 | openjdk8u342 | Andrew Hughes | P3 | Resolved | Fixed | b04 |
JDK-8284029 | 8u341 | Erik Joelsson | P3 | Resolved | Fixed | b02 |
We are currently using "hg tip" to create the "source_tips" file, and correspondingly for the closed bundles.
But this is incorrect. It will show the latest committed version in the repo, not the actual workspace (i.e. the version we actually build).
For this, we should use "hg id" instead. If we have a clean workspace updated to the tip, it will produce the same output. Otherwise it will show what we build, with a traliing "+" if there are local, non-committed changed.
Also, we should not name the file "tip" in this case.
And finally, we do not need to sprinkle these files all around in all repos. The entire handling should be more clearly abstracted.
But this is incorrect. It will show the latest committed version in the repo, not the actual workspace (i.e. the version we actually build).
For this, we should use "hg id" instead. If we have a clean workspace updated to the tip, it will produce the same output. Otherwise it will show what we build, with a traliing "+" if there are local, non-committed changed.
Also, we should not name the file "tip" in this case.
And finally, we do not need to sprinkle these files all around in all repos. The entire handling should be more clearly abstracted.
- backported by
-
JDK-8284029 Better model for storing source revision information
-
- Resolved
-
-
JDK-8287346 Better model for storing source revision information
-
- Resolved
-
- relates to
-
JDK-8222975 Fix 'release' file to reflect actual repo checkin used to compile JDK
-
- Resolved
-
-
JDK-8170392 JDK-8031567 broke builds from source bundles
-
- Resolved
-
(1 links to)