Details
-
Bug
-
Resolution: Fixed
-
P3
-
9
-
b08
Backports
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8208828 | 8u201 | Kevin Walls | P3 | Resolved | Fixed | b01 |
JDK-8201253 | 8u192 | Kevin Walls | P3 | Resolved | Fixed | b01 |
JDK-8216628 | emb-8u201 | Kevin Walls | P3 | Resolved | Fixed | master |
Description
This bug was triggered by the issue in JDK-8035725. Had the VS detection logic been more transparent, that bug would not have had to happen.
We need to rewrite the VS detection so that it is much more controlled, and do not run an unchecked shell script that modifies arbitrary environment variables. We can never re-create the same circumstances during "make time" as we have during "configure time" in that case. Instead, we should systematically set only those variables that are actually needed.
We need to rewrite the VS detection so that it is much more controlled, and do not run an unchecked shell script that modifies arbitrary environment variables. We can never re-create the same circumstances during "make time" as we have during "configure time" in that case. Instead, we should systematically set only those variables that are actually needed.
Attachments
Issue Links
- backported by
-
JDK-8201253 Clean up Visual Studio detection logic
- Resolved
-
JDK-8208828 Clean up Visual Studio detection logic
- Resolved
-
JDK-8216628 Clean up Visual Studio detection logic
- Resolved