Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8037953

configure usability: Should provide better details on imported hotspot

XMLWordPrintable

    • x86
    • linux_ubuntu

      A DESCRIPTION OF THE REQUEST :
      Whilst attempting to successfully run configure for builds with an imported hotspot i.e. using the --with-import-hotspot option, it became obvious that a new summary section identifying the version details for the imported pre-built hotspot would be more than useful.

      To this end, the following simple enhancement was implemented locally and is proposed here, in order to address this perceived shortfall.



      JUSTIFICATION :
      Although not strictly necessary, I believe that this enhancement would realise the joint benefits of being able to both verify that the imported hotspot build is actually the one being used in the build and also to readily determine the compatibility, or otherwise, of the hotspot with the posited build.

      EXPECTED VERSUS ACTUAL BEHAVIOR :
      EXPECTED -
      The configure summary should report the version of the hotspot iff the hotspot is imported - reporting the fact hat the hotspot is to be built otherwise - the patch generates an additional line in the configure tools summary as follows...

      Tools summary:
      * Boot JDK: java version "1.7.0_51" OpenJDK Runtime Environment (IcedTea 2.4.4) (7u51-2.4.4-0ubuntu0.12.04.2) OpenJDK Server VM (build 24.45-b08, mixed mode) (at /usr/lib/jvm/java-7-openjdk-i386)
      * Hotspot: java version "1.7.0" (at /home/dpointo8/sandbox/bootjvm/sdk70)
      * C Compiler: gcc-4.6 (Ubuntu/Linaro 4.6.3-1ubuntu5) version 4.6.3 (at /usr/bin/gcc-4.6)
      * C++ Compiler: g++-4.6 (Ubuntu/Linaro 4.6.3-1ubuntu5) version 4.6.3 (at /usr/bin/g++-4.6)

      ACTUAL -
      The hotspot version info is not present.

      ---------- BEGIN SOURCE ----------
      Not applicable
      ---------- END SOURCE ----------

      CUSTOMER SUBMITTED WORKAROUND :
      Rather than a workaround, the following is the patch for consideration to be pushed into the repo ...

      diff -r 1773f1fd0fac common/autoconf/help.m4
      --- a/common/autoconf/help.m4 Tue Mar 04 11:50:40 2014 -0800
      +++ b/common/autoconf/help.m4 Wed Mar 19 11:08:17 2014 +0000
      @@ -23,6 +23,10 @@
       # questions.
       #
       
      +#
      +# Portions Copyright (c) 2013 IBM Corporation
      +#
      +
       AC_DEFUN_ONCE([HELP_SETUP_DEPENDENCY_HELP],
       [
         AC_CHECK_PROGS(PKGHANDLER, apt-get yum port pkgutil pkgadd)
      @@ -202,6 +206,13 @@
           printf "* Environment: $WINDOWS_ENV_VENDOR version $WINDOWS_ENV_VERSION (root at $WINDOWS_ENV_ROOT_PATH)\n"
         fi
         printf "* Boot JDK: $BOOT_JDK_VERSION (at $BOOT_JDK)\n"
      + printf "* Hotspot: "
      + if test "x$with_import_hotspot" = x; then
      + printf "To be built\n"
      + else
      + hotspot_version="`$with_import_hotspot/bin/java -version 2>&1 | $HEAD -n1`"
      + printf "$hotspot_version (at $with_import_hotspot)\n"
      + fi
         printf "* C Compiler: $CC_VENDOR version $CC_VERSION (at $CC)\n"
         printf "* C++ Compiler: $CXX_VENDOR version $CXX_VERSION (at $CXX)\n"
       

            Unassigned Unassigned
            webbuggrp Webbug Group
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: