Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8041641

remove 2 arg version of SecurityBaseline.satisfiesBaselineStrictly()

XMLWordPrintable

    • b28

        The two arg version of satisfiesBaselineStrictly(version, baseline) is doing double duty - it is only used in 2 places and should be removed.
        Confusion is created by having this method, which:
        1.) confirms if version satisfies it's security baseline, and
        2.) confirms that the baseline passed in is actually the security baseline for the family used in the version passed in.
        This is used in JREMatcher.isDRSVersionMatch, when DRS version is "SECURE-XXX", after getting the baseline for version "XXX". Here it would be cleaner to separately check if XXX is the platform version of the version being checked, and that the version being checked satisfies it's baseline.
        The other place this is used is in SecurityBaseline.satisfiesDRSVersion() (when DRS version is "SECURE-XXX" . Here the check already exists that the requested version is from the XXX family, so it would be enough to jsut call the one arg version.

              herrick Andy Herrick (Inactive)
              herrick Andy Herrick (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: