Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8042806

Splashscreen uses libjpeg-internal macros

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4
    • 9
    • 9
    • client-libs
    • None
    • b15

    Description

      As indicated in the libjpeg API documentation [1], the standard libjpeg headers are: jpeglib.h, jerror.h, jconfig.h, jmorecfg.h

      splashscreen_jpeg.c violates this layering and uses the SIZEOF macro from the non-public header jinclude.h directly. This macro is a wrapper over sizeof. The code in splashscreen_jpeg.c already uses sizeof in multiple places so it seems like it should be okay to use it in some more.

      One additional motivation of having this patch is that if/when we add system-libjpeg support, the header jinclude.h will become inaccessible.

      [1] http://svn.code.sf.net/p/libjpeg-turbo/code/trunk/libjpeg.txt

      Attachments

        Activity

          People

            omajid Omair Majid
            omajid Omair Majid
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: