-
Enhancement
-
Resolution: Fixed
-
P4
-
9
-
b24
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8056621 | emb-9 | Unassigned | P4 | Resolved | Fixed | b24 |
JDK-8063561 | 8u45 | Stefan Karlsson | P4 | Resolved | Fixed | b01 |
JDK-8049547 | 8u40 | Stefan Karlsson | P4 | Resolved | Fixed | b02 |
JDK-8070841 | emb-8u47 | Stefan Karlsson | P4 | Resolved | Fixed | team |
Creation of RelocIterators show up high in profiles of the remark phase, in the G1 Class Unloading project.
There's a pattern in the nmethod/codecache code to create a RelocIterator and then materialize a CompiledIC:
RelocIterator iter(this, low_boundary);
while(iter.next()) {
if (iter.type() == relocInfo::virtual_call_type) {
CompiledIC *ic = CompiledIC_at(iter.reloc());
CompiledIC_at is implemented as:
new CompiledIC(call_site->code(), nativeCall_at(call_site->addr()));
And one of the first thing CompiledIC::CompiledIC(const nmethod* nm, NativeCall* call) does is to create a new RelocIterator:
...
address ic_call = call->instruction_address();
...
RelocIterator iter(nm, ic_call, ic_call+1);
bool ret = iter.next();
assert(ret == true, "relocInfo must exist at this address");
assert(iter.addr() == ic_call, "must find ic_call");
I would like to propose that we pass down the RelocIterator that we already have, instead of creating a new.
There's a pattern in the nmethod/codecache code to create a RelocIterator and then materialize a CompiledIC:
RelocIterator iter(this, low_boundary);
while(iter.next()) {
if (iter.type() == relocInfo::virtual_call_type) {
CompiledIC *ic = CompiledIC_at(iter.reloc());
CompiledIC_at is implemented as:
new CompiledIC(call_site->code(), nativeCall_at(call_site->addr()));
And one of the first thing CompiledIC::CompiledIC(const nmethod* nm, NativeCall* call) does is to create a new RelocIterator:
...
address ic_call = call->instruction_address();
...
RelocIterator iter(nm, ic_call, ic_call+1);
bool ret = iter.next();
assert(ret == true, "relocInfo must exist at this address");
assert(iter.addr() == ic_call, "must find ic_call");
I would like to propose that we pass down the RelocIterator that we already have, instead of creating a new.
- backported by
-
JDK-8049547 Add a version of CompiledIC_at that doesn't create a new RelocIterator
-
- Resolved
-
-
JDK-8056621 Add a version of CompiledIC_at that doesn't create a new RelocIterator
-
- Resolved
-
-
JDK-8063561 Add a version of CompiledIC_at that doesn't create a new RelocIterator
-
- Resolved
-
-
JDK-8070841 Add a version of CompiledIC_at that doesn't create a new RelocIterator
-
- Resolved
-