Details
-
Bug
-
Resolution: Fixed
-
P4
-
9
-
b25
-
Verified
Backports
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8056876 | emb-9 | Unassigned | P4 | Resolved | Fixed | b25 |
Description
LocalVariableTestBase has an expected dependency on LocalVariableTableTest.
A ...Test may depend on a ...TestBase, but a ...TestBase class should not depend on a ...Test.
If the use of that dependency is specific to LocalVariableTableTest, the functionality should be moved to the test. If the use of that dependency is shared by multiple tests, the code should be moved into ...TestBase.
In this case, there is an interface VariableTable with the following method:
List<LocalVariableTableTest.VariableTable.Entry> entries();
This would seem to imply that LocalVariableTableTest.VariableTable or LocalVariableTableTest.VariableTable.Entry should be moved to LocalVariableTestBase
A ...Test may depend on a ...TestBase, but a ...TestBase class should not depend on a ...Test.
If the use of that dependency is specific to LocalVariableTableTest, the functionality should be moved to the test. If the use of that dependency is shared by multiple tests, the code should be moved into ...TestBase.
In this case, there is an interface VariableTable with the following method:
List<LocalVariableTableTest.VariableTable.Entry> entries();
This would seem to imply that LocalVariableTableTest.VariableTable or LocalVariableTableTest.VariableTable.Entry should be moved to LocalVariableTestBase
Attachments
Issue Links
- backported by
-
JDK-8056876 LocalVariableTestBase has unexpected dependency on LocalVariableTableTest
-
- Resolved
-