Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8050319

LocalVariableTestBase has unexpected dependency on LocalVariableTableTest

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • 9
    • tools
    • b25
    • Verified

        LocalVariableTestBase has an expected dependency on LocalVariableTableTest.

        A ...Test may depend on a ...TestBase, but a ...TestBase class should not depend on a ...Test.

        If the use of that dependency is specific to LocalVariableTableTest, the functionality should be moved to the test. If the use of that dependency is shared by multiple tests, the code should be moved into ...TestBase.

        In this case, there is an interface VariableTable with the following method:
            List<LocalVariableTableTest.VariableTable.Entry> entries();
        This would seem to imply that LocalVariableTableTest.VariableTable or LocalVariableTableTest.VariableTable.Entry should be moved to LocalVariableTestBase

              anazarov Andrey Nazarov (Inactive)
              jjg Jonathan Gibbons
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: