Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8051680

(ref) unnecessary process_soft_ref_reconsider

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 18
    • 9
    • hotspot
    • None
    • gc
    • b06
    • generic
    • generic

    Description

      I think ReferenceProcessor::process_soft_ref_reconsider (formerly known as process_phase1) is unnecessary. It seems like it shouldn't find anything, because of the similar policy-based test in ReferenceProcessor::discover_reference. And if it does find anything, the liveness analysis from the referent is executed with discovery disabled, which I think is wrong for what is being done by this phase. I think we do need to be performing discovery on references found by chasing through the referents of soft references that we choose by policy to keep alive.

      So I think this phase is presently an expensive nop, and should be deleted entirely, along with supporting infrastructure such as DiscoveredListIterator::make_active(), which I think is only used here.

      Attachments

        Issue Links

          is blocked by

          Enhancement - null JDK-8269596 Snapshot soft ref policy before marking/copying

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Enhancement - null JDK-6990442 (ref) Regression to clearing of a softly reachable object

          • P3 - Major loss of function.
          • Open

          Enhancement - null JDK-6990438 (ref) Soft reference could consider strong if GC decides not to clear

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Enhancement - null JDK-8031401 Remove unused code in the reference processor

          • P3 - Major loss of function.
          • Resolved

          Enhancement - null JDK-8202845 Refactor reference processing for improved parallelism

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8270282 Semantically rename reference processing subphases

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          JEP - Java Enhancement Proposal JDK-8046124 JEP 134: Intuitive Semantics for Nested Reference Objects

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Candidate

          Enhancement - null JDK-8043575 Dynamically parallelize reference processing work

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jdk/86a20081

          Review Review openjdk/jdk/4667

          Activity

            People

              ayang Albert Yang
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: