Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8083509 | emb-9 | Marcus Larsson | P5 | Resolved | Fixed | team |
G1CollectorPolicy::record_concurrent_mark() contains the following code:
if (no_of_gc_threads > 0) {
...
} else {
assert(no_of_gc_threads > 0, ...);
}
The assert is wrong and will always fail. Apparently the else-part of that if is never executed.
Fix this code by:
- factor out the calculation of the WorkUnit variable into a method
- remove the else-part and simply assert at the beginning of the method that no_of_gc_threads must be > 0
- refactor the method, i.e. variable naming, according to coding guidelines
if (no_of_gc_threads > 0) {
...
} else {
assert(no_of_gc_threads > 0, ...);
}
The assert is wrong and will always fail. Apparently the else-part of that if is never executed.
Fix this code by:
- factor out the calculation of the WorkUnit variable into a method
- remove the else-part and simply assert at the beginning of the method that no_of_gc_threads must be > 0
- refactor the method, i.e. variable naming, according to coding guidelines
- backported by
-
JDK-8083509 Remove wrong assert and refactor code in G1CollectorPolicy::record_concurrent_mark_end
-
- Resolved
-