From Magnus' review mail:

* The new file GensrcProviders.gmk are included by the Gensrc files for jdk.attach and jdk.jdi, which only uses half of it each. Each half is just a few lines long. I believe a better solution is to remove the GensrcProviders.gmk file, move the process-provider macro to GensrcCommon.gmk and move the two actual rules to the respective module gensrc file.

* In the gensrc directory, there are now almost twice as many files. For many of them, the following pattern holds:
 GensrcOldStyle.gmk -- defines the actual logic for some gensrc target
 Gensrc-<module>.gmk -- does nothing but includes GensrcOldStyle.gmk

In these cases, I think the contents of GensrcOldStyle should be inlined directly in the Gensrc-<module>.gmk instead. This holds for all modules except the two mammuth modules java.base and java.desktop. (Depending on the treatment of GensrcProviders as described above.)